Separate repository home and browse view in tab menu
ClosedPublic
Actions

Authored by bekay on Feb 14 2024, 17:27.

Details

Reviewers

avivey
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15728: Repo home view and browse view share the same menu tab

Commits

rPba835fe0eced: Seperate repository home and browse view in tab menu

Summary

The tab menu in a repository can be a bit confusing. The first tab will be rendered active for two distinctive states:

the home view in the currently selected branch
the browse view in the currently selected branch

This diff will give the home view a dedicated extra tab. When switching the branches, we won't switch between home and browse view like it is done now.

And I have changed the crumb text for the browse view to "Code" to match it up with the tab name.

Additionally the readme is now the first content on the home view.

Fixes T15728

Test Plan

Browse in your favorite repos and feel an UX elevation.

Diff Detail

Repository

rP Phorge

Branch

T15728

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1140
Build 1140: arc lint + arc unit

Event Timeline

bekay created this revision.Feb 14 2024, 17:27

Owners added a reviewer: O1: Blessed Committers.Feb 14 2024, 17:27

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 14 2024, 17:27

bekay requested review of this revision.Feb 14 2024, 17:27

Harbormaster completed remote builds in B1064: Diff 1703.Feb 14 2024, 17:27

I'd even suggest we can go one step further, and in the Home tab show the Readme above the files (and maybe change the order/highlight some other UI elements too).

This revision is now accepted and ready to land.Mar 30 2024, 12:25

Moves readme to the top in home view

Harbormaster completed remote builds in B1140: Diff 1807.Apr 2 2024, 09:58

In D25538#16175, @avivey wrote:

I'd even suggest we can go one step further, and in the Home tab show the Readme above the files (and maybe change the order/highlight some other UI elements too).

Good idea! I have implemented the readme-at-top suggestion... maybe quite a big change, but I think with the new code tab and the locate input the UX isn't disrupted that much.

avivey accepted this revision.Apr 2 2024, 13:18

Congratulations to both bekay and avivey. Minimum change, maximum result.

bekay edited the summary of this revision. (Show Details)Apr 2 2024, 13:40

Closed by commit rPba835fe0eced: Seperate repository home and browse view in tab menu. · Explain WhyApr 2 2024, 13:56

This revision was automatically updated to reflect the committed changes.

bekay added a commit: rPba835fe0eced: Seperate repository home and browse view in tab menu.

Whops, typo "Seperate" in the title - sorry for not noticing

valerio.bozzolan mentioned this in Next Up.Apr 2 2024, 14:19

bekay retitled this revision from Seperate repository home and browse view in tab menu to Separate repository home and browse view in tab menu.Apr 2 2024, 14:36

20after4 awarded a token.Apr 2 2024, 19:19

valerio.bozzolan added a task: T15526: Diffusion: Description and tags are not shown.Apr 22 2024, 05:09

valerio.bozzolan mentioned this in T15526: Diffusion: Description and tags are not shown.Apr 22 2024, 05:11

valerio.bozzolan removed a task: T15526: Diffusion: Description and tags are not shown.Apr 22 2024, 08:29

avivey mentioned this in 2024 week 19.May 11 2024, 04:37