Page MenuHomePhorge
Create Task
Maniphest T15283

Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make CSS/JS load
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Install Phorge on a freshly set up Fedora 37 machine with PHP 8.1.18 installed; no existing previous MariaDB database.
  2. Apply patch from T15279/D25137

Actual outcome:

Get no CSS applied in web browser:

Screenshot from 2023-04-27 09-56-42.png (974×1 px, 254 KB)

[27-Apr-2023 07:53:36 UTC] [2023-04-27 07:53:36] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
[27-Apr-2023 07:53:36 UTC] arcanist(head=master, ref.master=82d1abd4edd1), phorge(head=T15279, ref.master=7b080db57c5b, ref.T15279=706064d0f127)
[27-Apr-2023 07:53:36 UTC]   #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/celerity/controller/CelerityResourceController.php:116]
[27-Apr-2023 07:53:36 UTC]   #1 <#2> CelerityResourceController::serveResource(array) called at [<phorge>/src/applications/celerity/controller/CelerityPhabricatorResourceController.php:37]
[27-Apr-2023 07:53:36 UTC]   #2 <#2> CelerityPhabricatorResourceController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284]
[27-Apr-2023 07:53:36 UTC]   #3 phlog(RuntimeException) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
[27-Apr-2023 07:53:36 UTC]   #4 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.p
hp:751]
[27-Apr-2023 07:53:36 UTC]   #5 AphrontApplicationConfiguration::handleThrowable(RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]
[27-Apr-2023 07:53:36 UTC]   #6 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontAppl
icationConfiguration.php:204]
[27-Apr-2023 07:53:36 UTC]   #7 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]

Expected outcome:

Screenshot from 2023-04-27 09-56-52.png (974×1 px, 151 KB)

Revisions and Commits

rP Phorge
D25138rPf3b37413167e Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make…

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusAssignedTask
· · ·
OpenNoneT15064 Make Phorge compatible with PHP 8.1/8.2/8.3/8.4
ResolvedaklapperT15283 Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make CSS/JS load
· · ·

Event Timeline

aklapper created this task.Apr 27 2023, 08:03
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptApr 27 2023, 08:03
aklapper added a revision: D25138: Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make CSS/JS load.Apr 27 2023, 08:10
valerio.bozzolan subscribed.Apr 27 2023, 08:24

(Thanks for the copy paste of the stack trace. I like that since it's really easy to find that from search engines)

valerio.bozzolan added a comment.Apr 27 2023, 08:35

By the way I don't know why you receive an error 500 for the favicon :) Maybe that deserves a separated troubleshooting

aklapper added a comment.Apr 27 2023, 08:46
In T15283#6919, @valerio.bozzolan wrote:

By the way I don't know why you receive an error 500 for the favicon :) Maybe that deserves a separated troubleshooting

One thing at a time, plus I'm only here in my free time. :) First need to make Phorge basically work and render on PHP 8.1/8.2; there's still lots of issues.
And AFAIK Debian 12 (Bookworm) will be out in June 2023 including PHP 8.2.

aklapper closed this task as Resolved by committing rPf3b37413167e: Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make….Apr 27 2023, 08:51
aklapper claimed this task.
aklapper added a commit: rPf3b37413167e: Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make….
valerio.bozzolan added a comment.Apr 27 2023, 08:52

Same and I agree on your concerns

In my opinion Phorge should not escalate any deprecation warning to a nuclear nuke, and should just log these instead. But in not bold enough for that change. In the meanwhile, these fixes are really appreciated.

valerio.bozzolan added a parent task: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.Apr 27 2023, 10:51
valerio.bozzolan added a project: PHP 8 support.
aklapper mentioned this in T15279: PHP 8.1 "strlen(null)" exceptions block rendering the Account Creation page after installation.Apr 27 2023, 12:21
avivey removed a project: Phorge.May 9 2023, 10:42
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0