Change Details

I tried using the [[ https://we.phorge.it/book/phorge/article/calendar_imports/ | Phorge/Phabricator Calendar import feature related to Importing .ics URIs]]. After importing specific events, for example from Google Calendar (bleah), it can happen that the Calendar's homepage becomes broken. This was the exception error shown to video: ``` Call to a member function getEventsBetween() on null ``` This NULL pointer is thrown since this method can return NULL and it needs proper checks when used: ``` PhabricatorCalendarEventQuery#newRecurrenceSet() ```

I tried using the [[ https://we.phorge.it/book/phorge/article/calendar_imports/ | Phorge/Phabricator Calendar import feature related to Importing .ics URIs]]. After importing specific events, for example from Google Calendar (bleah), it can happen that the Calendar's homepage becomes broken. This was the exception error shown to video: ``` Call to a member function getEventsBetween() on null ``` This NULL pointer is thrown since this method can return NULL and it needs proper checks when used: ``` PhabricatorCalendarEventQuery#newRecurrenceSet() ``` ---- It seems this change was also fixed in 2019 by Wikimedia folks but never sent to upstream: https://phabricator.wikimedia.org/rPHABd7744d7e9bd05d3117b1a128a95231a8ee148b5e https://phabricator.wikimedia.org/T220241 We could evaluate if they had a different approach.

I tried using the [[ https://we.phorge.it/book/phorge/article/calendar_imports/ | Phorge/Phabricator Calendar import feature related to Importing .ics URIs]]. After importing specific events, for example from Google Calendar (bleah), it can happen that the Calendar's homepage becomes broken. This was the exception error shown to video: ``` Call to a member function getEventsBetween() on null ``` This NULL pointer is thrown since this method can return NULL and it needs proper checks when used: ``` PhabricatorCalendarEventQuery#newRecurrenceSet() ``` ---- It seems this change was also fixed in 2019 by Wikimedia folks but never sent to upstream: https://phabricator.wikimedia.org/rPHABd7744d7e9bd05d3117b1a128a95231a8ee148b5e https://phabricator.wikimedia.org/T220241 We could evaluate if they had a different approach.