Differential D25965

Disable opening of hovercard if trigger node is inside hovercard
AcceptedPublic
Actions

Authored by bekay on Tue, Apr 15, 17:35.

Details

Reviewers

aklapper

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16029: Hovercard trigger inside hovercard content closes hovercard

Summary

If the content of a hovercard contains another hovercard trigger, the initial hovercard will be closed when entering the inside trigger with the mouse. You can see the bug with every differential hovercard which contains reviewers. But there are other cases too: For example if project descriptions use mentions or other project tags.

This fix is pretty easy and returns inside the mousemove handler if the trigger node has a closest ancestor with the class "jx-hovercard-container".

Closes T16029

Test Plan

See if a hovercard is closed if you enter following inside the hovercard:

reviewers inside differential hovercard
people mentions or other project tags inside project hovercard

Diff Detail

Repository

rP Phorge

Branch

T16029

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1873
Build 1873: arc lint + arc unit

Event Timeline

bekay created this revision.Tue, Apr 15, 17:35

Owners added a reviewer: O1: Blessed Committers.Tue, Apr 15, 17:35

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Apr 15, 17:35

bekay requested review of this revision.Tue, Apr 15, 17:35

Harbormaster completed remote builds in B1873: Diff 2886.Tue, Apr 15, 17:35

aklapper edited the summary of this revision. (Show Details)Wed, Apr 16, 07:42

Uh nice, thank you! This seems to work as expected:

Screenshot From 2025-04-16 11-10-04.png (289×916 px, 66 KB)

I wonder if this also influences T15884: "Uncaught TypeError: spec is undefined" and no hovercard over task link in Aphlict notification which I do not manage to reproduce right now (and that might instead be related to running a newer node-ws version locally)

This revision is now accepted and ready to land.Wed, Apr 16, 09:12

aklapper retitled this revision from Disables opening of hovercard if trigger node is inside hovercard to Disable opening of hovercard if trigger node is inside hovercard.Wed, Apr 16, 09:13

aklapper edited the test plan for this revision. (Show Details)

In D25965#25711, @aklapper wrote:

Uh nice, thank you! This seems to work as expected:

I wonder if this also influences T15884: "Uncaught TypeError: spec is undefined" and no hovercard over task link in Aphlict notification which I do not manage to reproduce right now (and that might instead be related to running a newer node-ws version locally)

Mh... The notification is inside a container with the class "jx-notification-container" - so my condition would not catch this case. I think these two error are unrelated...