Differential D25797
Drop question mark suffix from optional PHPDoc @param types Authored by aklapper on Aug 22 2024, 09:59. Tags None Referenced Files
Subscribers
Details
The question mark in @param type? $foo Desc is a custom notation not consistently applied across the codebase and not necessarily obvious to the reader (because custom and not mentioned in https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc.md ). Closes T15925. Run PHPStan, see no PHPDoc @param has invalid value (type? [...] style output anymore.
Diff Detail
Event TimelineComment Actions I confirm with my hand on my heart that I've consumed my eyes inspecting every single line to be absolutely sure that this PHPDoc probably has a better meaning and will not cause nuclear implosions.  Comment Actions @valerio.bozzolan: Thank you! I know this is super boring work, but it allows PHPStan to show other type/class issues which are currently hidden due to PHPStan barking earlier about that non-standard question mark when parsing those lines. :-/ |