When looking at a commit/revision, allow to copy the path of a file to the clipboard, so you can quickly open that file in your local code checkout from the command line.
Closes T15897
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15897: Allow to copy file path from file header in web changeset view
- Commits
- rPec6ba6966686: Add Copy file path button to file header bar in Differential/Diffusion
Open a proposed commit in Differential or a merged commit in Diffusion. Click the "Copy file path" button, paste that clipboard content.
Change the width of the viewport and see that the button is not rendered when in phone mode.
Run ./bin/celerity map again and no changes.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- differentialCopyPath
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1479 Build 1479: arc lint + arc unit
Event Timeline
Comment Actions
OH GOSH YES
What about replacing that legacy "unuseful" file icon on the left, with your new copy-button?
Benefits:
- we replace an unuseful "document" icon with an useful one (believe me or not, but I always click on that damn icon on the left, expecting it copies the name)
- we save more space
- if we have a lot of file, the copy button is always in the same horizontal position
Comment Actions
What about replacing that legacy "unuseful" file icon on the left, with your new copy-button?
I was initially reluctant as that might destroy information but seeing that I can still get that golden strip on the right by clicking anywhere in the file header bar and that the icon on the very left is also duplicated in the file tree view above (though icons inconsistently differ for map.php between and anyway), I probably agree with you.