When you drag and drop a file in a Conpherence chat,
the file was only visible by the author.
Now the file is also attached to that chat, making it visible.
This is a follow-up from:
https://we.phorge.it/D25705?id=2178
Refs T15106
Differential D25709
Fix missing file attachment in Conpherence mturdus on Jul 1 2024, 11:58. Authored by
Details
When you drag and drop a file in a Conpherence chat, Now the file is also attached to that chat, making it visible. This is a follow-up from: https://we.phorge.it/D25705?id=2178 Refs T15106
Diff Detail
Event TimelineComment Actions To avoid that $xactions[0] we should probably find the desired transaction. Note: At the moment we lack a similar commodity method to find transactions, but that would be probably appreciated: $xaction_comment = PhabricatorTransactions::findOneByType( $xactions, PhabricatorTransactions::TYPE_COMMENT); Here what I'm talking about adopting findOneByType(): https://we.phorge.it/D25710?vs=2188&id=2189#toc This new method "find transaction by type" opens some creative space to apply some minor refactors here and there: and other things related to grep -F -C10 -R 'foreach ($xactions as $x' . | grep "if.*Type.*==" -C 4
Comment Actions P.S. Why does Phriction have the field text_metadata? And why does Conpherence have content_metadata? 🤔 Comment Actions it's the other way around. For Conpherence, the content is stored in a property named text and the file PHIDs are stored in the corresponding text_metadata. Maniphest tasks have description and description_metadata. Comment Actions OK. @avivey what do you think about a new silly commodity method PhabricatorTransactions::findOneByType(array, string) ? Maybe you have a strong opinion Comment Actions Please wait at least for another +1, or, a week, before landing this. Since others may have different opinions on PhabricatorTransactions::findOneByType(). Thanks, tested, finally I share a file and people see it also in Conpherence 🌈 awesome Comment Actions I've seen worse 🤷🏻♂️
Comment Actions Double-slam-accept! Thanks and happy landing
|