Differential D25408

Fix Exception in Chat room when you are not a Participant
ClosedPublic
Actions

Authored by valerio.bozzolan on Aug 18 2023, 08:55.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15497: Exception when viewing incoming Chat room messages, when not in Participants

Commits

rP8507d3a95072: Fix Exception in Chat room when you are not a Participant

Summary

After this change you can lurk in public chats, and receive notifications, without crashing your planet.

Fix exception "Undefined index: PHID-USER-..." shown to newcomers when they are receiving messages
from a public Chat they are not members of.

Closes T15497

Test Plan

Have the Notification server (Aphlict) enabled and running. https://we.phorge.it/book/phorge/article/notifications/
Be user Alice and visit a Conpherence Room. Alice must be not a participant.
Be user Bob and send a message in that Room.

Now Alice does not see a crash anymore, but the message from Bob.

Diff Detail

Repository

rP Phorge

Branch

arcpatch-D25408

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 898
Build 898: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Aug 18 2023, 08:55

Owners added a reviewer: O1: Blessed Committers.Aug 18 2023, 08:55

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptAug 18 2023, 08:55

valerio.bozzolan requested review of this revision.Aug 18 2023, 08:55

Harbormaster completed remote builds in B781: Diff 1297.Aug 18 2023, 08:55

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47

valerio.bozzolan mentioned this in T15497: Exception when viewing incoming Chat room messages, when not in Participants.Aug 22 2023, 12:18

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39

valerio.bozzolan added inline comments.Oct 13 2023, 13:22

src/applications/conpherence/controller/ConpherenceUpdateController.php
378	Interestingly the page was already prepared to receive no participant. So the Diff is still consistent I hope.

valerio.bozzolan mentioned this in Z1: Phorge.Oct 16 2023, 19:21

Basically, it works :D

speck accepted this revision.Nov 8 2023, 23:17

speck subscribed.

speck added inline comments.

src/applications/conpherence/controller/ConpherenceUpdateController.php
344	Could you add a comment either here or above and reference the task? I think it will help in the future as it seems weird a user would be here but not be a participant.

This revision is now accepted and ready to land.Nov 8 2023, 23:17

valerio.bozzolan marked an inline comment as done.Nov 9 2023, 06:30

Follow review tips

Harbormaster completed remote builds in B898: Diff 1458.Nov 9 2023, 06:31

valerio.bozzolan edited the summary of this revision. (Show Details)Nov 9 2023, 06:32

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan edited the summary of this revision. (Show Details)Nov 9 2023, 06:36

Closed by commit rP8507d3a95072: Fix Exception in Chat room when you are not a Participant. · Explain WhyNov 9 2023, 20:06

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP8507d3a95072: Fix Exception in Chat room when you are not a Participant.

valerio.bozzolan mentioned this in Next Up.Nov 9 2023, 20:06

avivey mentioned this in 2023 week 49.Dec 8 2023, 17:36