Page MenuHomePhorge

Fix Exception in Chat room when you are not a Participant
ClosedPublic

Authored by valerio.bozzolan on Aug 18 2023, 08:55.
Tags
None
Referenced Files
F1407944: D25408.id1462.diff
Sat, Feb 24, 00:11
F1407885: D25408.id1297.diff
Sat, Feb 24, 00:05
F1407314: D25408.id1458.diff
Fri, Feb 23, 22:04
Unknown Object (File)
Fri, Feb 23, 21:34
Unknown Object (File)
Wed, Feb 21, 07:16
Unknown Object (File)
Wed, Feb 21, 05:22
Unknown Object (File)
Jan 21 2024, 06:27
Unknown Object (File)
Jan 21 2024, 06:26

Details

Summary

After this change you can lurk in public chats, and receive notifications, without crashing your planet.

Fix exception "Undefined index: PHID-USER-..." shown to newcomers when they are receiving messages
from a public Chat they are not members of.

Closes T15497

Test Plan

Now Alice does not see a crash anymore, but the message from Bob.

Diff Detail

Repository
rP Phorge
Branch
fix-conpherence-viewing
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 781
Build 781: arc lint + arc unit

Event Timeline

src/applications/conpherence/controller/ConpherenceUpdateController.php
378

Interestingly the page was already prepared to receive no participant. So the Diff is still consistent I hope.

speck subscribed.
speck added inline comments.
src/applications/conpherence/controller/ConpherenceUpdateController.php
339

Could you add a comment either here or above and reference the task? I think it will help in the future as it seems weird a user would be here but not be a participant.

This revision is now accepted and ready to land.Nov 8 2023, 23:17
valerio.bozzolan edited the test plan for this revision. (Show Details)