Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step in Harbormaster
ClosedPublic

Authored by aklapper on Aug 6 2023, 21:08.
Tags
None
Referenced Files
F2310142: D25379.1721385141.diff
Thu, Jul 18, 10:32
F2309796: D25379.1721366612.diff
Thu, Jul 18, 05:23
F2309780: D25379.1721365421.diff
Thu, Jul 18, 05:03
Unknown Object (File)
Wed, Jul 17, 16:15
Unknown Object (File)
Tue, Jul 16, 15:52
Unknown Object (File)
Tue, Jul 16, 15:52
Unknown Object (File)
Thu, Jul 11, 03:36
Unknown Object (File)
Tue, Jul 9, 10:44

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=customOAuthUrlencodeNull, ref.master=788098096e11, ref.customOAuthUrlencodeNull=4f0f2043b7e9), phorge(head=master, ref.master=226f3150933d)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:271]

Closes T15594

Test Plan

Add a build step in Harbormaster, select "Interacting with External Build Systems > Build with Buildkite" at /harbormaster/step/new/1/HarbormasterBuildkiteBuildStepImplementation/, select the "Create Build Step" button. Page now shows several expected error messages (API Token is required; Organization Name is required; etc) instead of a PHP error.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable