Paths

Table of Contentst

Differential D25174

Remove PHP Safe Mode related code
AbandonedPublic
Actions

Authored by aklapper on May 2 2023, 13:14.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 07:11

	Unknown Object (File)
	Thu, Apr 11, 01:58

	Unknown Object (File)
	Tue, Apr 9, 20:22

	Unknown Object (File)
	Mon, Apr 8, 22:31

	Unknown Object (File)
	Mon, Apr 8, 22:26

	Unknown Object (File)
	Sat, Apr 6, 05:30

	Unknown Object (File)
	Thu, Apr 4, 13:11

	Unknown Object (File)
	Mon, Apr 1, 01:27

View All 55 Files

Subscribers

valerio.bozzolan

Tokens

"Manufacturing Defect?" token, awarded by valerio.bozzolan.

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15329: Remove PHP Safe Mode related code

Summary

PHP "Safe Mode" feature has been deprecated as of PHP 5.3.0 and removed as of PHP 5.4.0.

Phorge requires PHP 5.5 or newer.

Closes T15329

Test Plan

Not sure. Managed to still install Phorge on PHP 8.1 after removing these lines.

Diff Detail

Repository

Branch

rmSafeMode (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 334
Build 334: arc lint + arc unit

Event Timeline

aklapper created this revision.May 2 2023, 13:14

Owners added a reviewer: O1: Blessed Committers.May 2 2023, 13:14

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 2 2023, 13:14

aklapper requested review of this revision.May 2 2023, 13:14

Harbormaster completed remote builds in B334: Diff 621.May 2 2023, 13:14

Why won't this software run with safe_mode enabled?

A change without a test plan is just a bug report waiting to happen.

This revision now requires changes to proceed.May 2 2023, 13:33

In D25174#5371, @avivey wrote:

Why won't this software run with safe_mode enabled?

How to enable safe_mode in PHP 5.5 or newer when Safe Mode was removed in PHP 5.4 && when Phorge requires PHP 5.5 or newer anyway according to the Phorge docs?

Anyway, looking at Phorge's code now it seems to lack a check that the PHP version is 5.5 or newer. That would indeed be something to add first, before thinking of this patch. Abandoning for the time being.

aklapper mentioned this in T15329: Remove PHP Safe Mode related code.May 2 2023, 14:06

valerio.bozzolan awarded a token.May 2 2023, 20:59

Revision Contents
Changeset List

Path

Size

Packages

externals/

phpmailer/

class.phpmailer-lite.php

2 lines

O1: Blessed Committers

class.phpmailer.php

2 lines

O1: Blessed Committers

src/

applications/

config/

check/

PhabricatorPHPPreflightSetupCheck.php

19 lines

O1: Blessed Committers

Diff 621

externals/phpmailer/class.phpmailer-lite.php

Loading...

externals/phpmailer/class.phpmailer.php

Loading...

src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php

Loading...