Page MenuHomePhorge
Differential D25134

Drag & Drop: fix JavaScript error related to JX.$(undefined)
ClosedPublic
Actions

Authored by valerio.bozzolan on Apr 25 2023, 14:24.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 10:49
Unknown Object (File)
Thu, Apr 25, 10:49
Unknown Object (File)
Wed, Apr 24, 22:23
Unknown Object (File)
Wed, Apr 24, 21:17
Unknown Object (File)
Sat, Apr 13, 06:18
Unknown Object (File)
Sat, Apr 13, 06:02
Unknown Object (File)
Sat, Apr 13, 06:00
Unknown Object (File)
Fri, Apr 12, 14:55
View All 73 Files
Subscribers
Cigaryno
Dylsss
Matthew
speck
tobiaswiese

Details

Reviewers
Dylsss
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15272: RemarkupMetadata.js - Error: Empty ID passed to JX.$()!
Commits
rP7bd4089a2694: Drag & Drop: fix JavaScript error related to JX.$(undefined)
Summary

This change fixes the following recent JavaScript error:

Error: Empty ID passed to JX.$()!

The regression was introduced here:

90f9da643d1622bcfff3a8903159aeefd1b42520

Closes T15272

Test Plan
  • with this change I was able to open Conpherence Persistent Chat and Drop a file

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 268
Build 268: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Apr 25 2023, 14:24
Owners added a reviewer: O1: Blessed Committers.Apr 25 2023, 14:24
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptApr 25 2023, 14:24
Harbormaster completed remote builds in B268: Diff 524.Apr 25 2023, 14:24
valerio.bozzolan requested review of this revision.Apr 25 2023, 14:24
valerio.bozzolan mentioned this in rP90f9da643d16: Add and use new RemarkupMetadata class.Apr 25 2023, 14:29
valerio.bozzolan added a reviewer: Dylsss.Apr 25 2023, 14:43
valerio.bozzolan added a subscriber: Dylsss.

Thanks @Dylsss for any opinion about this small fix

valerio.bozzolan mentioned this in Z1: Phorge.Apr 25 2023, 14:54
valerio.bozzolan mentioned this in Next Up (since Week 18).Apr 25 2023, 20:35
avivey accepted this revision.Apr 26 2023, 06:51
This revision is now accepted and ready to land.Apr 26 2023, 06:51
valerio.bozzolan added a comment.Apr 26 2023, 07:50

I damn like avivey when runs like:

yesyes

Closed by commit rP7bd4089a2694: Drag & Drop: fix JavaScript error related to JX.$(undefined). · Explain WhyApr 26 2023, 07:51
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rP7bd4089a2694: Drag & Drop: fix JavaScript error related to JX.$(undefined).
avivey mentioned this in T15276: changes to js files should always invoke PhabricatorCelerityTestCase.Apr 26 2023, 10:10
valerio.bozzolan added a comment.Apr 26 2023, 10:16

The unit test was happy even if ./bin/celerity map was needed. Again.

jackie_chan_wtf

To find a scientific answer I will start debugging ./src/__tests__/PhabricatorCelerityTestCase.php in the future.

valerio.bozzolan mentioned this in D25136: Fix outdated Celerity.Apr 26 2023, 10:24
valerio.bozzolan mentioned this in rP1e27a7b89944: Fix outdated Celerity.Apr 26 2023, 10:26

Revision Contents
Changeset List

PathSizePackages
webroot/
rsrc/
js/
core/
14 linesO1: Blessed Committers

Diff 524

View Options

webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0