Fix a PHP 8.1 issue related to preg_match() and null subject
ClosedPublic
Actions

Authored by valerio.bozzolan on Apr 14 2023, 14:02.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated"
T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo)

Commits

rARCf4a639944de4: Fix a PHP 8.1 issue related to preg_match() and null subject

Summary

This change fixes 'arc patch' in some circumstances.

Closes T15254

Test Plan

I was able to run "arc patch D25111" without issues

Diff Detail

Repository

rARC Arcanist

Branch

fix-deprecated-preg_match-81

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 249
Build 249: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	ArcanistRepositoryAPIMiscTestCase::testSVNFileEscapes EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703) #1 /var/www/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
	0 ms	ArcanistRepositoryAPIStateTestCase::testGitStateParsing EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703) #1 /var/www/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
	0 ms	ArcanistRepositoryAPIStateTestCase::testHgStateParsing EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703) #1 /var/www/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
	0 ms	ArcanistRepositoryAPIStateTestCase::testSvnStateParsing EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703) #1 /var/www/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
	0 ms	PhutilLibraryTestCase::testEverythingImplemented EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703) #1 /var/www/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
		View Full Test Results (7 Failed)

Event Timeline

valerio.bozzolan created this revision.Apr 14 2023, 14:02

Owners added a reviewer: O1: Blessed Committers.Apr 14 2023, 14:02

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptApr 14 2023, 14:02

valerio.bozzolan requested review of this revision.Apr 14 2023, 14:02

Harbormaster completed remote builds in B249: Diff 490.Apr 14 2023, 14:02

valerio.bozzolan retitled this revision from Fix a PHP 8.1 issue related to preg_match() and null subject This change fixes 'arc patch' in some circumstances. to Fix a PHP 8.1 issue related to preg_match() and null subject.Apr 14 2023, 14:04

valerio.bozzolan edited the summary of this revision. (Show Details)

enable xdebug to make lint happy

Harbormaster completed remote builds in B250: Diff 491.Apr 14 2023, 14:05

valerio.bozzolan mentioned this in T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).Apr 14 2023, 14:09

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan added a task: T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated".

Hi @Matthew - probably you will love this small and cute one that fix a PHP 8.1

Have a nice week-end

LGTM

This revision is now accepted and ready to land.Apr 14 2023, 18:45

Closed by commit rARCf4a639944de4: Fix a PHP 8.1 issue related to preg_match() and null subject. · Explain WhyApr 14 2023, 20:13

This revision was automatically updated to reflect the committed changes.