Page MenuHomePhorge

Workboard: in some cases, increase menu opacity (accessibility)
ClosedPublic

Authored by valerio.bozzolan on Mar 23 2023, 18:08.
Tags
None
Referenced Files
F2231503: D25088.1718761703.diff
Tue, Jun 18, 01:48
Unknown Object (File)
Sat, Jun 15, 09:14
Unknown Object (File)
Sun, Jun 9, 13:12
Unknown Object (File)
Sat, Jun 8, 20:43
Unknown Object (File)
Sat, Jun 8, 06:14
Unknown Object (File)
Tue, Jun 4, 21:38
Unknown Object (File)
Fri, May 31, 19:40
Unknown Object (File)
Thu, May 30, 05:09

Details

Summary

This change contains a very minimal graphical change for Workboards
with a custom background.

https://we.phorge.it/T15186

After this change, if your Workboard has a custom background color,
the opacity of the floating menu of the Column is not 0.9 but 0.95,
so it's increased a bit. The problem with the previous value, is that
when you open the menu, you see too much text underneath, and this
could worsen the readability. Now also probably, but less I hope.

Closes T15186

Test Plan
  • Workboard > Change Background Color > Pick a nice color
  • Backlog > Edit
  • Enjoy the extra 0.05 of opacity of that menu
  • NEVER ACCEPT IF YOUR EYES DETECT JUST A 0.04999998 OF EXTRA OPACITY

Diff Detail

Repository
rP Phorge
Branch
opacity
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 165
Build 165: arc lint + arc unit

Event Timeline

Hi @Cigaryno - I will offer you an authentic Phorge doublon for your review here

This revision is now accepted and ready to land.Mar 27 2023, 18:40

You need to run the Celerity scripts!

In D25088#3046, @avivey wrote:

You need to run the Celerity scripts!

jackie_chan_wtf

Whops :O I misunderstood in Jitsi. I was blinded by the green light.

Maybe we can land this:

D25025: Unify user-select CSS directives

That now has the celerity map up to date with webroot/rsrc/css/phui/workboards/phui-workboard-color.css