Page MenuHomePhorge

Drag & Drop: set a link as external
ClosedPublic

Authored by valerio.bozzolan on Mar 17 2023, 12:20.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 19:34
Unknown Object (File)
Mon, Mar 25, 06:46
Unknown Object (File)
Sun, Mar 24, 05:51
Unknown Object (File)
Thu, Mar 21, 10:55
Unknown Object (File)
Thu, Mar 21, 02:32
Unknown Object (File)
Wed, Mar 20, 23:50
Unknown Object (File)
Wed, Mar 20, 10:02
Unknown Object (File)
Feb 23 2024, 15:00

Details

Summary

Rest assured: external links remain evil, by default.

Don't adopt them randomly by induction.

Whether you believe it or not, this specific external
link merited some deep thoughts on Phorge:

So, whenever you use a mouse, a finger, or whenever we have
a confirmation dialog or not to prevent onblur disasters,
this change is probably consistent with common expectations.

Having said, external links remain evil - by default.

Closes T15172

Test Plan
  • Drag & Drop a File on a Remarkup text
  • click on the link inside the popup
  • it opens in a new tab (without risk of form loss)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fix lint error "Line Too Long"

This revision is now accepted and ready to land.Mar 17 2023, 12:54