replace usage of each() with foreach() for smtp
ClosedPublic
Actions

Authored by MacFan4000 on Nov 27 2022, 21:20.

Details

Reviewers

• dsadad
avivey
valerio.bozzolan

Group Reviewers

O1: Blessed Committers
Blessed Committers

Commits

rP9623e6674588: replace usage of each() with foreach() for smtp

Summary

this replaces uses with warning suppression of each() (depreccated in
PHP7, removed in PHP8) with foreach

Test Plan

can verify that these chages do work (tested on my own install)

Diff Detail

Repository

rP Phorge

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 105
Build 105: arc lint + arc unit

Event Timeline

MacFan4000 created this revision.Nov 27 2022, 21:20

Owners added a reviewer: O1: Blessed Committers.Nov 27 2022, 21:20

Herald added subscribers: Matthew, valerio.bozzolan, tobiaswiese, speck. · View Herald TranscriptNov 27 2022, 21:20

MacFan4000 requested review of this revision.Nov 27 2022, 21:20

Harbormaster completed remote builds in B94: Diff 289.Nov 27 2022, 21:20

MacFan4000 added a reviewer: Blessed Committers.Nov 27 2022, 21:21

Cigaryno subscribed.Dec 16 2022, 10:36

• dsadad accepted this revision.Dec 17 2022, 16:34

Is this even used?
Looks like the file is currently in Windows mode; can you please split this to 2 diffs, or just keep the original line-ending?

Yes it is used for mailing via smtp, so probably most installs use it

fix

Harbormaster completed remote builds in B104: Diff 305.Jan 28 2023, 19:00

fix

Harbormaster completed remote builds in B105: Diff 306.Jan 28 2023, 19:08

avivey accepted this revision.Feb 2 2023, 19:05

This revision is now accepted and ready to land.Feb 2 2023, 19:05

If somebody could land this at some point, that would be great!

I will land since the author asked this kind of help, and avivey confirmed, and also asked to keep the same "no newline at end of file" and that's respected.

valerio.bozzolan accepted this revision.Mar 3 2023, 18:26

Closed by commit rP9623e6674588: replace usage of each() with foreach() for smtp. · Explain WhyMar 3 2023, 18:28

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP9623e6674588: replace usage of each() with foreach() for smtp.

Revision Contents
Changeset List

Path

Size

Packages

externals/

phpmailer/

class.smtp.php

1626 lines

O1: Blessed Committers

Diff 306

View Options

externals/phpmailer/class.smtp.php

replace usage of each() with foreach() for smtpClosedPublicActions