Page MenuHomePhorge

replace usage of each() with foreach() for smtp
ClosedPublic

Authored by MacFan4000 on Nov 27 2022, 21:20.
Tags
None
Referenced Files
F2061828: D25059.id329.diff
Thu, Mar 28, 14:04
F2055910: D25059.id.diff
Thu, Mar 28, 00:51
F2054649: D25059.diff
Wed, Mar 27, 18:44
Unknown Object (File)
Tue, Mar 26, 08:58
Unknown Object (File)
Sun, Mar 24, 05:41
Unknown Object (File)
Thu, Mar 21, 04:42
Unknown Object (File)
Thu, Mar 21, 03:35
Unknown Object (File)
Wed, Mar 20, 16:49

Details

Summary

this replaces uses with warning suppression of each() (depreccated in
PHP7, removed in PHP8) with foreach

Test Plan

can verify that these chages do work (tested on my own install)

Diff Detail

Repository
rP Phorge
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 104
Build 104: arc lint + arc unit

Event Timeline

  1. Is this even used?
  2. Looks like the file is currently in Windows mode; can you please split this to 2 diffs, or just keep the original line-ending?

Yes it is used for mailing via smtp, so probably most installs use it

This revision is now accepted and ready to land.Feb 2 2023, 19:05

If somebody could land this at some point, that would be great!

I will land since the author asked this kind of help, and avivey confirmed, and also asked to keep the same "no newline at end of file" and that's respected.