Page MenuHomePhorge

User-CigarynoProject
ActivePublic

Members (1)

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

This is @Cigaryno's workboard. Tasks created by/assigned to this user goes here.

Recent Activity

Yesterday

Cigaryno closed D25936: Mark Phorge.it Home as non-launchable.
Mon, Mar 31, 14:21 · User-Cigaryno, phorge.it install
Cigaryno closed T16018: Update TOTP suggestions to open-source applications as Resolved by committing rPf6639cc09c3d: Update TOTP suggestions to open-source applications.
Mon, Mar 31, 13:54 · User-Cigaryno, Auth
Cigaryno closed D25934: Update TOTP suggestions to open-source applications.
Mon, Mar 31, 13:54 · User-Cigaryno, Auth
aklapper accepted D25934: Update TOTP suggestions to open-source applications.

Looks good to me, thanks!

Mon, Mar 31, 13:01 · User-Cigaryno, Auth
avivey accepted D25936: Mark Phorge.it Home as non-launchable.

Looks good, yeah.

Mon, Mar 31, 06:51 · User-Cigaryno, phorge.it install

Sun, Mar 30

aklapper added a comment to D25935: Require MFA to uninstall apps if enabled.

Why would a cancel URI be needed?

Sun, Mar 30, 22:04 · Security, User-Cigaryno
Cigaryno added a reviewer for D25936: Mark Phorge.it Home as non-launchable: avivey.

@avivey does this look good to you?

Sun, Mar 30, 21:53 · User-Cigaryno, phorge.it install
aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

But so far this is nothing meant to be hidden from users who can't edit the repo.

Sun, Mar 30, 20:52 · User-Cigaryno, Diffusion
Cigaryno added a comment to D25935: Require MFA to uninstall apps if enabled.

After these steps I get Unhandled Exception ("Exception"): This transaction group requires MFA to apply, but the Editor was not configured with a Cancel URI. This workflow can not perform an MFA check.

Why would a cancel URI be needed? Do you know a Cancel URI for an app with something that prompts for MFA (ie. exposing Passphrases, empowering users, signing comments with MFA, managing your VCS password and SSH keys)

Sun, Mar 30, 20:51 · Security, User-Cigaryno
aklapper added a comment to D25935: Require MFA to uninstall apps if enabled.

Which "an application" exactly?

Any application were canUninstall is not set to false (thus not a required application).

That's what I tested (as the Files application can be uninstalled). Which exact application(s) did you test?
I'm surprised that you did not run into the same problem as I did described in my last comment...maybe it's related to not being an admin?

Sun, Mar 30, 20:46 · Security, User-Cigaryno
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

Socially I remain unconvinced about use cases. Implications are for example exposing hidden (or internal?) URIs under URIs or "Working Copy Status" stuff under Basics to the public. I just so far do not think it's a good idea.

Sun, Mar 30, 20:44 · User-Cigaryno, Diffusion
aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

Tested this locally; technically it looks correct to me.

Sun, Mar 30, 20:42 · User-Cigaryno, Diffusion
aklapper updated the test plan for D25926: Make Diffusion repository management accessible to logged-out users.
Sun, Mar 30, 20:41 · User-Cigaryno, Diffusion
Cigaryno added a comment to D25935: Require MFA to uninstall apps if enabled.

Which "an application" exactly?

Any application were canUninstall is not set to false (thus not a required application).

As which type of user?

A user with the Can Configure Application capability (by default admins).

Sun, Mar 30, 20:31 · Security, User-Cigaryno
Cigaryno updated the diff for D25934: Update TOTP suggestions to open-source applications.

Fix typos reported by @aklapper.

Sun, Mar 30, 20:27 · User-Cigaryno, Auth
Cigaryno added a comment to D25936: Mark Phorge.it Home as non-launchable.

@Cigaryno: Thanks! Could you elaborate why the change in .arcconfig is needed?

Sun, Mar 30, 20:15 · User-Cigaryno, phorge.it install
aklapper requested changes to D25935: Require MFA to uninstall apps if enabled.

Clear Test Plans with URIs are welcome - the less others need to think "how/where to do that" the easier gets testing.

Sun, Mar 30, 20:13 · Security, User-Cigaryno
aklapper updated the test plan for D25936: Mark Phorge.it Home as non-launchable.
Sun, Mar 30, 19:54 · User-Cigaryno, phorge.it install
aklapper added a comment to D25936: Mark Phorge.it Home as non-launchable.

@Cigaryno: Thanks! Could you elaborate why the change in .arcconfig is needed?

Sun, Mar 30, 19:53 · User-Cigaryno, phorge.it install
aklapper requested changes to D25934: Update TOTP suggestions to open-source applications.

Should be fine after these two changes :)

Sun, Mar 30, 19:11 · User-Cigaryno, Auth
aklapper added inline comments to D25934: Update TOTP suggestions to open-source applications.
Sun, Mar 30, 19:11 · User-Cigaryno, Auth
Cigaryno added a comment to D25936: Mark Phorge.it Home as non-launchable.

I don't know why, but O1 has to be manually added as a reviewer as it does not own R10.

Sun, Mar 30, 10:04 · User-Cigaryno, phorge.it install
Cigaryno added a reviewer for D25936: Mark Phorge.it Home as non-launchable: O1: Blessed Committers.
Sun, Mar 30, 10:03 · User-Cigaryno, phorge.it install
Cigaryno requested review of D25936: Mark Phorge.it Home as non-launchable.
Sun, Mar 30, 10:02 · User-Cigaryno, phorge.it install
AndrewTavis added a comment to T16018: Update TOTP suggestions to open-source applications.

Thank you both for the conversation here and further thanks @Cigaryno for the patch! :)

Sun, Mar 30, 09:57 · User-Cigaryno, Auth

Sat, Mar 29

Cigaryno updated the diff for D25935: Require MFA to uninstall apps if enabled.

Make lint happy

Sat, Mar 29, 16:43 · Security, User-Cigaryno
Cigaryno requested review of D25935: Require MFA to uninstall apps if enabled.
Sat, Mar 29, 16:40 · Security, User-Cigaryno
Cigaryno updated the diff for D25934: Update TOTP suggestions to open-source applications.

Mention closed-source apps in addition to open-source apps per @aklapper

Sat, Mar 29, 14:28 · User-Cigaryno, Auth
Cigaryno planned changes to D25934: Update TOTP suggestions to open-source applications.

Per @aklapper, it's best to show both closed-source and open-source TOTP apps.

I'd personally not remove common proprietary software options (as it makes life of users potentially harder if they already have such an app installed) but list FOSS options first.

Some FoSS devs may not be familiar at all with open-source TOTP apps. I personally use Google Authenticator so I agree with you and also, I have my TOTP content on WinAuth too, which is unmaintained however I am not ready to switch TOTP app on my Windows PC (my revs from now on are created from an Ubuntu VM due to the arc troubles I am having on Windows).

Sat, Mar 29, 14:24 · User-Cigaryno, Auth
Cigaryno added a comment to T16018: Update TOTP suggestions to open-source applications.

I'd personally not remove common proprietary software options (as it makes life of users potentially harder if they already have such an app installed) but list FOSS options first.

Sat, Mar 29, 14:02 · User-Cigaryno, Auth
Cigaryno added a comment to D25934: Update TOTP suggestions to open-source applications.

I'd prefer not to remove common proprietary software options but list FOSS options first.

Sat, Mar 29, 13:55 · User-Cigaryno, Auth
aklapper added a comment to T16018: Update TOTP suggestions to open-source applications.

I'd personally not remove common proprietary software options (as it makes life of users potentially harder if they already have such an app installed) but list FOSS options first.

Sat, Mar 29, 13:43 · User-Cigaryno, Auth
aklapper added a comment to D25934: Update TOTP suggestions to open-source applications.

I'd prefer not to remove common proprietary software options but list FOSS options first.

Sat, Mar 29, 13:43 · User-Cigaryno, Auth
Cigaryno requested review of D25934: Update TOTP suggestions to open-source applications.
Sat, Mar 29, 13:21 · User-Cigaryno, Auth
Cigaryno added a revision to T16018: Update TOTP suggestions to open-source applications: D25934: Update TOTP suggestions to open-source applications.
Sat, Mar 29, 13:21 · User-Cigaryno, Auth
Cigaryno claimed T16018: Update TOTP suggestions to open-source applications.

I will submit a patch shortly.

Sat, Mar 29, 13:12 · User-Cigaryno, Auth
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

What is there to "further review"? It's two lines...

Sat, Mar 29, 10:58 · User-Cigaryno, Diffusion
aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

What is there to "further review"? It's two lines...

Sat, Mar 29, 10:12 · User-Cigaryno, Diffusion
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

Can this be further reviewed?

Sat, Mar 29, 09:24 · User-Cigaryno, Diffusion

Wed, Mar 26

aklapper closed T16007: Discuss the policy for contributing to prototype applications as Resolved by committing rP29866413d1c7: Diviner: Contributing Code: Update section on Prototype Changes.
Wed, Mar 26, 16:15 · Discussion Needed, User-Cigaryno
aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

robots.txt can have the solution for that (see below).
[...]
For search engines, the solution is to add this to robots.txt:

In theory yes if everyone behaved. In practice, robots.txt is ignored and LLM/AI crawlers are ruthless. (For example, GNOME GitLab admins recently installed Anubis to run background checks on your machine.)

Wed, Mar 26, 13:02 · User-Cigaryno, Diffusion
Cigaryno updated the test plan for D25926: Make Diffusion repository management accessible to logged-out users.
Wed, Mar 26, 12:44 · User-Cigaryno, Diffusion
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
  • more search engine rabbit holes (but maybe not that bad)

robots.txt can have the solution for that (see below).

Wed, Mar 26, 12:41 · User-Cigaryno, Diffusion
valerio.bozzolan added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

Uhm. Good points:

Wed, Mar 26, 12:30 · User-Cigaryno, Diffusion
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

Why would a logged-out user (who does not want to or cannot create an account) want to know about Repository management log or Repository limits? I don't see how that's their business (or interest)?

Wed, Mar 26, 12:29 · User-Cigaryno, Diffusion
Cigaryno added a comment to T15999: Make Phorge more accessible to logged-out users.

Some items in the task description make me a bit uncomfortable in my instance.

I don't think you need to be uncomfortable on your instance (phabricator.wikimedia.org)
For Herald, it looks to be restricted to trusted contributors to restrict who can create personal rules (they actually can vandalize tasks via personal rules with the action set to claim the task), that's not something to take care of at all on your instance.
Project members, maniphest reports, user tasks and badges are actually useful for logged-out users.
But everything that's Diffusion-related sounds pointless for your instance as every repo is a read-only mirror of the repos on a Gerrit instance.

Wed, Mar 26, 12:26 · User-Cigaryno
aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

Why would a logged-out user (who does not want to or cannot create an account) want to know about Repository management log or Repository limits? I don't see how that's their business (or interest)?

Wed, Mar 26, 11:58 · User-Cigaryno, Diffusion
aklapper added a comment to T15999: Make Phorge more accessible to logged-out users.

Some items in the task description make me a bit uncomfortable in my instance. Why does everyone need to see Diffusion sync, pull, and push logs? Why Herald transcripts? Why repo management if you cannot manage? What are actual use cases which outweigh security implications?

Wed, Mar 26, 11:57 · User-Cigaryno
Cigaryno updated the task description for T15999: Make Phorge more accessible to logged-out users.
Wed, Mar 26, 11:23 · User-Cigaryno
Cigaryno added a revision to T15999: Make Phorge more accessible to logged-out users: D25926: Make Diffusion repository management accessible to logged-out users.
Wed, Mar 26, 11:16 · User-Cigaryno