User-CigarynoProject
ActivePublic
Watch Project

Members (1)

Cigaryno (Cigaryno MD)
Scripter
View All

Watchers

This project does not have any watchers.
View All

Details

Description

This is @Cigaryno's workboard. Tasks created by/assigned to this user goes here.

Recent Activity
View All

Fri, Apr 25

danielyepezgarces added a comment to T15056: Improve Dark Mode.

Ok, I'll improve it, because I still have a lot to learn about Phorge and its source code, otherwise I'll fix those issues myself

Fri, Apr 25, 06:47 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

aklapper added a comment to T15056: Improve Dark Mode.

If there is an issue in Phorge then please provide steps to reproduce in Phorge. Please also strip unneeded full quotes which make comments hard to read. Thanks!

Fri, Apr 25, 06:20 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

danielyepezgarces added a comment to T15056: Improve Dark Mode.

In T15056#21737, @danielyepezgarces wrote:

T391929 In that task on Wikimedia Phabricator, I had put some issues

Steps to reproduce the bug:

Enable the "Dark Mode (Experimental)" theme in Wikimedia Phabricator.

Go to the Phabricator Workboard.

Click on any button that has a dropdown menu.

And with these steps you can see the error like the images I have attached

I just checked that the issue can be replicated in the Accessibility workboard, on the Affects-Wikimedia workboard it looks good

Fri, Apr 25, 05:45 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

danielyepezgarces added a comment to T15056: Improve Dark Mode.

In T15056#21750, @aklapper wrote:

In T15056#21737, @danielyepezgarces wrote:

@danielyepezgarces: Please always provide clear steps to reproduce something somewhere, in most recent Phorge itself.

Fri, Apr 25, 05:33 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

Tue, Apr 22

valerio.bozzolan updated the task description for T15513: Cannot edit Conpherence rooms on mobile.

Tue, Apr 22, 15:30 · User-Cigaryno, Mobile, Conpherence, Bug Reports

aklapper placed T15513: Cannot edit Conpherence rooms on mobile up for grabs.

Fix was reverted for now as it had bad side effects.

Tue, Apr 22, 13:17 · User-Cigaryno, Mobile, Conpherence, Bug Reports

aklapper reopened T15513: Cannot edit Conpherence rooms on mobile as Open by committing rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile".

Tue, Apr 22, 13:16 · User-Cigaryno, Mobile, Conpherence, Bug Reports

aklapper added a revision to T15513: Cannot edit Conpherence rooms on mobile: D25969: Revert "Fix editing Conpherence rooms on mobile".

Tue, Apr 22, 12:55 · User-Cigaryno, Mobile, Conpherence, Bug Reports

Mon, Apr 21

aklapper added a comment to T15056: Improve Dark Mode.

In T15056#21737, @danielyepezgarces wrote:

Mon, Apr 21, 11:59 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

danielyepezgarces added a comment to T15056: Improve Dark Mode.

T391929 In that task on Wikimedia Phabricator, I had put some issues

Mon, Apr 21, 01:15 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

Mar 31 2025

Cigaryno closed D25936: Mark Phorge.it Home as non-launchable.

Mar 31 2025, 14:21 · User-Cigaryno, phorge.it install

Cigaryno closed T16018: Update TOTP suggestions to open-source applications as Resolved by committing rPf6639cc09c3d: Update TOTP suggestions to open-source applications.

Mar 31 2025, 13:54 · User-Cigaryno, Auth

Cigaryno closed D25934: Update TOTP suggestions to open-source applications.

Mar 31 2025, 13:54 · User-Cigaryno, Auth

aklapper accepted D25934: Update TOTP suggestions to open-source applications.

Looks good to me, thanks!

Mar 31 2025, 13:01 · User-Cigaryno, Auth

avivey accepted D25936: Mark Phorge.it Home as non-launchable.

Looks good, yeah.

Mar 31 2025, 06:51 · User-Cigaryno, phorge.it install

Mar 30 2025

aklapper added a comment to D25935: Require MFA to uninstall apps if enabled.

In D25935#25149, @Cigaryno wrote:

Why would a cancel URI be needed?

Mar 30 2025, 22:04 · Security, User-Cigaryno

Cigaryno added a reviewer for D25936: Mark Phorge.it Home as non-launchable: avivey.

@avivey does this look good to you?

Mar 30 2025, 21:53 · User-Cigaryno, phorge.it install

aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

In D25926#25147, @Cigaryno wrote:

But so far this is nothing meant to be hidden from users who can't edit the repo.

Mar 30 2025, 20:52 · User-Cigaryno, Diffusion

Cigaryno added a comment to D25935: Require MFA to uninstall apps if enabled.

In D25935#25135, @aklapper wrote:

After these steps I get Unhandled Exception ("Exception"): This transaction group requires MFA to apply, but the Editor was not configured with a Cancel URI. This workflow can not perform an MFA check.

Why would a cancel URI be needed? Do you know a Cancel URI for an app with something that prompts for MFA (ie. exposing Passphrases, empowering users, signing comments with MFA, managing your VCS password and SSH keys)

Mar 30 2025, 20:51 · Security, User-Cigaryno

aklapper added a comment to D25935: Require MFA to uninstall apps if enabled.

In D25935#25144, @Cigaryno wrote:

In D25935#25135, @aklapper wrote:

Which "an application" exactly?

Any application were canUninstall is not set to false (thus not a required application).

That's what I tested (as the Files application can be uninstalled). Which exact application(s) did you test?
I'm surprised that you did not run into the same problem as I did described in my last comment...maybe it's related to not being an admin?

Mar 30 2025, 20:46 · Security, User-Cigaryno

Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

In D25926#25145, @aklapper wrote:

Socially I remain unconvinced about use cases. Implications are for example exposing hidden (or internal?) URIs under URIs or "Working Copy Status" stuff under Basics to the public. I just so far do not think it's a good idea.

Mar 30 2025, 20:44 · User-Cigaryno, Diffusion

aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.

Tested this locally; technically it looks correct to me.

Mar 30 2025, 20:42 · User-Cigaryno, Diffusion

aklapper updated the test plan for D25926: Make Diffusion repository management accessible to logged-out users.

Mar 30 2025, 20:41 · User-Cigaryno, Diffusion

Cigaryno added a comment to D25935: Require MFA to uninstall apps if enabled.

In D25935#25135, @aklapper wrote:

Which "an application" exactly?

Any application were canUninstall is not set to false (thus not a required application).

As which type of user?

A user with the Can Configure Application capability (by default admins).

Mar 30 2025, 20:31 · Security, User-Cigaryno

Cigaryno updated the diff for D25934: Update TOTP suggestions to open-source applications.

Fix typos reported by @aklapper.

Mar 30 2025, 20:27 · User-Cigaryno, Auth

Cigaryno added a comment to D25936: Mark Phorge.it Home as non-launchable.

In D25936#25132, @aklapper wrote:

@Cigaryno: Thanks! Could you elaborate why the change in .arcconfig is needed?

Mar 30 2025, 20:15 · User-Cigaryno, phorge.it install

aklapper requested changes to D25935: Require MFA to uninstall apps if enabled.

Clear Test Plans with URIs are welcome - the less others need to think "how/where to do that" the easier gets testing.

Mar 30 2025, 20:13 · Security, User-Cigaryno

aklapper updated the test plan for D25936: Mark Phorge.it Home as non-launchable.

Mar 30 2025, 19:54 · User-Cigaryno, phorge.it install

aklapper added a comment to D25936: Mark Phorge.it Home as non-launchable.

@Cigaryno: Thanks! Could you elaborate why the change in .arcconfig is needed?

Mar 30 2025, 19:53 · User-Cigaryno, phorge.it install

aklapper requested changes to D25934: Update TOTP suggestions to open-source applications.

Should be fine after these two changes :)

Mar 30 2025, 19:11 · User-Cigaryno, Auth

aklapper added inline comments to D25934: Update TOTP suggestions to open-source applications.

Mar 30 2025, 19:11 · User-Cigaryno, Auth

Cigaryno added a comment to D25936: Mark Phorge.it Home as non-launchable.

I don't know why, but O1 has to be manually added as a reviewer as it does not own R10.

Mar 30 2025, 10:04 · User-Cigaryno, phorge.it install

Cigaryno added a reviewer for D25936: Mark Phorge.it Home as non-launchable: O1: Blessed Committers.

Mar 30 2025, 10:03 · User-Cigaryno, phorge.it install

Cigaryno requested review of D25936: Mark Phorge.it Home as non-launchable.

Mar 30 2025, 10:02 · User-Cigaryno, phorge.it install

AndrewTavis added a comment to T16018: Update TOTP suggestions to open-source applications.

Thank you both for the conversation here and further thanks @Cigaryno for the patch! :)

Mar 30 2025, 09:57 · User-Cigaryno, Auth

Mar 29 2025

Cigaryno updated the diff for D25935: Require MFA to uninstall apps if enabled.

Make lint happy

Mar 29 2025, 16:43 · Security, User-Cigaryno

Cigaryno requested review of D25935: Require MFA to uninstall apps if enabled.

Mar 29 2025, 16:40 · Security, User-Cigaryno

Cigaryno updated the diff for D25934: Update TOTP suggestions to open-source applications.

Mention closed-source apps in addition to open-source apps per @aklapper

Mar 29 2025, 14:28 · User-Cigaryno, Auth

Cigaryno planned changes to D25934: Update TOTP suggestions to open-source applications.

Per @aklapper, it's best to show both closed-source and open-source TOTP apps.

In T16018#21478, @Cigaryno wrote:

In T16018#21476, @aklapper wrote:

I'd personally not remove common proprietary software options (as it makes life of users potentially harder if they already have such an app installed) but list FOSS options first.

Some FoSS devs may not be familiar at all with open-source TOTP apps. I personally use Google Authenticator so I agree with you and also, I have my TOTP content on WinAuth too, which is unmaintained however I am not ready to switch TOTP app on my Windows PC (my revs from now on are created from an Ubuntu VM due to the arc troubles I am having on Windows).

Mar 29 2025, 14:24 · User-Cigaryno, Auth

Cigaryno added a comment to T16018: Update TOTP suggestions to open-source applications.

In T16018#21476, @aklapper wrote:

I'd personally not remove common proprietary software options (as it makes life of users potentially harder if they already have such an app installed) but list FOSS options first.

Mar 29 2025, 14:02 · User-Cigaryno, Auth

Cigaryno added a comment to D25934: Update TOTP suggestions to open-source applications.

In D25934#25089, @aklapper wrote:

I'd prefer not to remove common proprietary software options but list FOSS options first.

Mar 29 2025, 13:55 · User-Cigaryno, Auth

aklapper added a comment to T16018: Update TOTP suggestions to open-source applications.

I'd personally not remove common proprietary software options (as it makes life of users potentially harder if they already have such an app installed) but list FOSS options first.

Mar 29 2025, 13:43 · User-Cigaryno, Auth

aklapper added a comment to D25934: Update TOTP suggestions to open-source applications.

I'd prefer not to remove common proprietary software options but list FOSS options first.

Mar 29 2025, 13:43 · User-Cigaryno, Auth

Cigaryno requested review of D25934: Update TOTP suggestions to open-source applications.

Mar 29 2025, 13:21 · User-Cigaryno, Auth

Cigaryno added a revision to T16018: Update TOTP suggestions to open-source applications: D25934: Update TOTP suggestions to open-source applications.

Mar 29 2025, 13:21 · User-Cigaryno, Auth

Cigaryno claimed T16018: Update TOTP suggestions to open-source applications.

I will submit a patch shortly.

Mar 29 2025, 13:12 · User-Cigaryno, Auth

Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.