Page MenuHomePhorge
Feed Advanced Search

Jan 25 2024

CryingWolf created T15721: Commits in Phorge stuck on 'Still Importing'.
Jan 25 2024, 14:06

Aug 20 2023

avivey added a parent task for T15250: Raw use of "git diff" provides insufficient Diff Context: T15535: Using Differential with plain Git, without requiring Arc.
Aug 20 2023, 08:20 · Affects-FreeBSD, Differential

Aug 6 2023

valerio.bozzolan renamed T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends from Generate [From, Subject, Date] fields in download raw .diff URL to Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
Aug 6 2023, 19:59 · Affects-FreeBSD, Differential

Jul 26 2023

avivey updated the task description for T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
Jul 26 2023, 15:48 · Affects-FreeBSD, Differential
valerio.bozzolan added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

Uh thanks! Feel free to increase the "Hours invested" counter in the Task description ihih

Jul 26 2023, 07:22 · Affects-FreeBSD, Differential
avivey added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

Ok, I got bored.

Jul 26 2023, 04:47 · Affects-FreeBSD, Differential
avivey added a revision to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends: D25359: Generate more fields in Download Raw Diff.
Jul 26 2023, 04:43 · Affects-FreeBSD, Differential
avivey added a revision to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends: D25358: Let ArcanistBundle print some Git patch headers.
Jul 26 2023, 04:36 · Affects-FreeBSD, Differential

Jul 22 2023

avivey added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

My plan is:

  • If there's a commit information in the revision, use the author name and email from there. Not that this might not be the same as the revision's Author
  • If there's no git commit - use author name from Author field, and make up email address (annonymos@example.com).
Jul 22 2023, 21:42 · Affects-FreeBSD, Differential
ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

@avivey Yes I think this is what we need.
There is a caveat though:

Jul 22 2023, 20:50 · Affects-FreeBSD, Differential
avivey added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

@ton - this is what I have so far:

Jul 22 2023, 13:10 · Affects-FreeBSD, Differential

Jun 22 2023

ton updated the task description for T15364: arc land complaints summary by FreeBSD community.
Jun 22 2023, 15:03 · Arcanist, Differential, Affects-FreeBSD
valerio.bozzolan added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

Probably this is a good starting point to understand what to do:

Jun 22 2023, 13:27 · Affects-FreeBSD, Differential

Jun 2 2023

speck added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

Arcanist internally generates a diff that includes a similar suggested parameter to account for the entire file contents being present in the resulting diff.

Jun 2 2023, 03:44 · Affects-FreeBSD, Differential

May 22 2023

20after4 added a comment to T15364: arc land complaints summary by FreeBSD community.
In T15364#8952, @avivey wrote:

"tooling for chains of diffs" might need its own topic, with a design of the what the whole thing should look like in an ideal world, and how to get to it.
Even if not all of the stuff fits nicely into Phorge, there's probably a lot that can work, and some conduit methods can be added to implement the rest.

May 22 2023, 01:32 · Arcanist, Differential, Affects-FreeBSD

May 15 2023

avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

"tooling for chains of diffs" might need its own topic, with a design of the what the whole thing should look like in an ideal world, and how to get to it.
Even if not all of the stuff fits nicely into Phorge, there's probably a lot that can work, and some conduit methods can be added to implement the rest.

May 15 2023, 20:07 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15364: arc land complaints summary by FreeBSD community.

Chaining Diffs is something that we would like to use more often, and it is definitely not used enough today. FreeBSD is a large codebase and making any change that is bigger than trivial often involves touching multiple parts of the system, the most difficult kind of change is architectural changes. We are limited by our tooling to a certain degree:

  • Keeping everything in one Diff makes it very difficult to review as well as reach consensus, as there are often multiple responsible parties involved. It also violates the ethos of Phab/Phorge of having small atomic changes.
  • Breaking changes down in smaller chunks has lots of downsides too - it is very hard to track and changes often get lost in depths of Differential.
May 15 2023, 19:55 · Arcanist, Differential, Affects-FreeBSD
avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

mmm... I've never really worked where many changes are made of lots of dependent revisions - it's possible I've never even seen a chain of 3 revisions in the same repo. So I'm not sure about workflows for this kind of scenarios.

May 15 2023, 19:43 · Arcanist, Differential, Affects-FreeBSD
bsdimp added a comment to T15364: arc land complaints summary by FreeBSD community.

Yea, today I have about 50 lines of shell scripting that gets the different bits of data from the condon API point and then bashes them into a nearly acceptable commit message....

May 15 2023, 19:37 · Arcanist, Differential, Affects-FreeBSD
avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

Ok, so here's my thoughts on moving this forward:

May 15 2023, 06:56 · Arcanist, Differential, Affects-FreeBSD

May 9 2023

ton updated subscribers of T15364: arc land complaints summary by FreeBSD community.
May 9 2023, 18:48 · Arcanist, Differential, Affects-FreeBSD
ton updated subscribers of T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
May 9 2023, 18:48 · Affects-FreeBSD, Differential
ton updated subscribers of T15250: Raw use of "git diff" provides insufficient Diff Context.
May 9 2023, 18:47 · Affects-FreeBSD, Differential

May 8 2023

20after4 added a comment to T15364: arc land complaints summary by FreeBSD community.

FWIW I think the test plan is configurable (that requirement can be disabled in phabricator's config server side which should remove it from commit messages in arc)

May 8 2023, 18:21 · Arcanist, Differential, Affects-FreeBSD
avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

What are the reasons for doing commit message rendering on the server side?

May 8 2023, 06:57 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15364: arc land complaints summary by FreeBSD community.

In an ideal world the solution should be as simple as having a template somewhere in {{repo_root}}/.arcanist/commit_template.j2 that arcanist injects values in and renders.

May 8 2023, 01:55 · Arcanist, Differential, Affects-FreeBSD

May 7 2023

avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

We can probably come up with a way to allow an extension to customize the "render template" implementation without forking (e.g., just add a hook in differential.getcommitmessage), but it would have to be very carful about the whole form-thing.
Maybe just adding an "for landing" flag in differential.getcommitmessage (or adding a different method) would solve this problem...

May 7 2023, 20:12 · Arcanist, Differential, Affects-FreeBSD
avivey added a comment to T15364: arc land complaints summary by FreeBSD community.
In T15364#8281, @ton wrote:

The template is actually generated server side, not in arcanist, so it just a matter of getting the BSD Phorge server to have the right opinions.
Some of the sections can be configured already

Please point me in the right place in the code where I can find the template

May 7 2023, 20:06 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15364: arc land complaints summary by FreeBSD community.

The template is actually generated server side, not in arcanist, so it just a matter of getting the BSD Phorge server to have the right opinions.
Some of the sections can be configured already

May 7 2023, 18:56 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15364: arc land complaints summary by FreeBSD community.

re @avivey : arc land --hold sort of works but look at the ergonomics:

May 7 2023, 16:42 · Arcanist, Differential, Affects-FreeBSD
valerio.bozzolan renamed T15364: arc land complaints summary by FreeBSD community from arc land complaints summary to arc land complaints summary by FreeBSD community.
May 7 2023, 09:27 · Arcanist, Differential, Affects-FreeBSD
avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

Alternatively - there's also arc land --hold, which does almost everything except for the git push, which would allow the user to update the commit message. Have anyone tried that?

May 7 2023, 09:27 · Arcanist, Differential, Affects-FreeBSD
valerio.bozzolan added a parent task for T15364: arc land complaints summary by FreeBSD community: T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
May 7 2023, 09:26 · Arcanist, Differential, Affects-FreeBSD
avivey added a comment to T15364: arc land complaints summary by FreeBSD community.

thanks @ton - these look very actionable:

May 7 2023, 09:25 · Arcanist, Differential, Affects-FreeBSD
avivey added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
In T15249#8232, @ton wrote:

@avivey today I tried arc patch to download a bunch of Diffs.

Some diffs check out OK. Lots of Diffs fail to be fetched, I get a very useless error message:

Exception
strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
(Run with `--trace` for a full exception trace.)
May 7 2023, 09:16 · Affects-FreeBSD, Differential
ton updated the task description for T15364: arc land complaints summary by FreeBSD community.
May 7 2023, 06:35 · Arcanist, Differential, Affects-FreeBSD
ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
May 7 2023, 03:03 · Affects-FreeBSD, Differential

May 6 2023

ton created T15364: arc land complaints summary by FreeBSD community.
May 6 2023, 23:08 · Arcanist, Differential, Affects-FreeBSD

Apr 28 2023

ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

@avivey many developers do not use arcanist at all for reasons outlined in https://we.phorge.it/T15096#6224 - many do not wish to install php, some find arc interface confusing...

Apr 28 2023, 16:13 · Affects-FreeBSD, Differential
avivey added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

@ton: Why are "they" not using arc patch to download the patch?

Apr 28 2023, 15:28 · Affects-FreeBSD, Differential

Apr 21 2023

avivey added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

T15011: Build a Phorge Developer Environment

Apr 21 2023, 08:58 · Affects-FreeBSD, Differential
valerio.bozzolan added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

This?

Apr 21 2023, 08:57 · Affects-FreeBSD, Differential
speck added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

I wanted to set up some docker/compose file or possibly a VM but didn’t get far since neither of those are great solutions on windows, primarily for getting local code into the container/vm. My goal would be to get a quick setup time with a rapid dev/test cycle. For me to make progress I’ll likely have to switch to mac or Linux.

Apr 21 2023, 01:44 · Affects-FreeBSD, Differential

Apr 20 2023

valerio.bozzolan added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
In T15249#6474, @speck wrote:

Getting set up with a development environment (including database~) along with configuring the local instance and populating it with sample data is extremely daunting and is frankly why I haven’t done much contributing. I lost my dev environment a few years ago and have tried only once to get set back up, spent a few hours and never came back to it. It doesn’t help that arcanist’s self linter isn’t usable on windows systems.

I suspect the barrier is more the dev environment and less PHP or the codebase.

Apr 20 2023, 06:52 · Affects-FreeBSD, Differential

Apr 19 2023

speck added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

Getting set up with a development environment (including database~) along with configuring the local instance and populating it with sample data is extremely daunting and is frankly why I haven’t done much contributing. I lost my dev environment a few years ago and have tried only once to get set back up, spent a few hours and never came back to it. It doesn’t help that arcanist’s self linter isn’t usable on windows systems.

Apr 19 2023, 23:55 · Affects-FreeBSD, Differential
valerio.bozzolan added a project to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends: Affects-FreeBSD.
Apr 19 2023, 07:29 · Affects-FreeBSD, Differential
valerio.bozzolan added a project to T15250: Raw use of "git diff" provides insufficient Diff Context: Affects-FreeBSD.
Apr 19 2023, 07:29 · Affects-FreeBSD, Differential
valerio.bozzolan created Affects-FreeBSD.
Apr 19 2023, 07:29