Update as per peer review
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 4 2023
Jul 4 2023
Sten updated the diff for D25323: Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector().
Yeah - spotted & fixed!
Sten updated the diff for D25323: Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector().
PHP != Perl
Jul 3 2023
Jul 3 2023
Sten requested review of D25324: Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error.
Sten updated the summary of D25323: Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector().
Sten requested review of D25323: Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector().
Jul 1 2023
Jul 1 2023
Sten added a comment to D25319: Make src/infrastructure/javelin/markup.php phabricator_form PHP 8.1 compliant.
In D25319#9336, @speck wrote:Is there another place not specifying the method for a form? I don’t think that attribute should be optional and instead the fix is to explicitly declare GET or POST or PUT for forms.
Jun 30 2023
Jun 30 2023
Sten updated the diff for D25319: Make src/infrastructure/javelin/markup.php phabricator_form PHP 8.1 compliant.
Yes - much nicer. Thanks!
Sten updated the summary of D25318: Fix PHP 8.1 strlen() error when database replication Seconds_Behind_Master is NULL.
Jun 21 2023
Jun 21 2023
Wanted to ensure you had a chance to check the changes I made based on your review first...
Jun 19 2023
Jun 19 2023
Agreed. The more often we specify the path, the more likely the reader will remember it.
Downside is we need to lose the path/to/ in order to keep lint happy.
Agreed. The more often we specify the path, the more likely the reader will remember it.
valerio.bozzolan awarded D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php a Party Time token.
Sten updated the test plan for D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Sten updated the diff for D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Agreed - tighter check is better, and does fix the issue.
Jun 18 2023
Jun 18 2023
Sten added a comment to D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
It is 'arc unit' which doesn't work for us without this patch under PHP 8.1. We are using a version of ArcanistUnitTestEngine extended to handle multiple languages in a single repo, and I unfortunately cannot share this. I'm not sure what more you want - we have a unit test demonstrating strlen() is being used against a variable which can be null.
Jun 16 2023
Jun 16 2023
Sten updated the diff for D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Added unit test
Sten updated the summary of D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Sten requested review of D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Apr 8 2023
Apr 8 2023
Sten added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
In T15096#2230, @20after4 wrote:Honestly the effort to set up arcanist isn't huge (the flow for setting up your CLI cert couldn't be more perfect and user friendly IMO) and it's all worth it because of the productivity gained by automatic lint fixes, easy patch submission and code review checkouts (arc patch is awesome!)
Feb 1 2023
Feb 1 2023
Aug 8 2022
Aug 8 2022
I got differential working under PHP 8.1 by doing a global replace of single parameter strlen commands to add the null coalesce operator
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0