Page MenuHomePhorge
Feed Advanced Search

Jun 12 2023

aklapper closed D25287: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history.
Jun 12 2023, 00:51
aklapper closed T15463: PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history as Resolved by committing rP9b99123ff931: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository….
Jun 12 2023, 00:51 · PHP 8 support
aklapper committed rP9b99123ff931: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository….
Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository…
Jun 12 2023, 00:51
aklapper requested review of D25287: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history.
Jun 12 2023, 00:34
aklapper added a revision to T15463: PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history: D25287: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history.
Jun 12 2023, 00:34 · PHP 8 support
aklapper created T15463: PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history.
Jun 12 2023, 00:33 · PHP 8 support
aklapper requested review of D25286: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code.
Jun 12 2023, 00:26
aklapper added a revision to T15462: PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code: D25286: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code.
Jun 12 2023, 00:26 · PHP 8 support
aklapper created T15462: PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code.
Jun 12 2023, 00:25 · PHP 8 support
aklapper requested review of D25285: Fix PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags.
Jun 12 2023, 00:07
aklapper added a revision to T15461: PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags: D25285: Fix PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags.
Jun 12 2023, 00:07 · PHP 8 support
aklapper created T15461: PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags.
Jun 12 2023, 00:06 · PHP 8 support

Jun 11 2023

aklapper updated the task description for T15460: PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding.
Jun 11 2023, 23:21 · PHP 8 support
aklapper requested review of D25284: Fix PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding.
Jun 11 2023, 23:15
aklapper added a revision to T15460: PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding: D25284: Fix PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding.
Jun 11 2023, 23:15 · PHP 8 support
aklapper created T15460: PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding.
Jun 11 2023, 23:14 · PHP 8 support
aklapper added a comment to D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.

I suggest that, also because this is supposed to be a low-level phutil utility and probably should be as fast and simple as possible

Jun 11 2023, 22:59
aklapper updated the test plan for D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.
Jun 11 2023, 22:58
aklapper updated the diff for D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.

Simply pass the Exception from mb_convert_encoding() to the UI when trying to change repo to an invalid encoding (as proposed by valerio.bozzolan)

Jun 11 2023, 22:58
aklapper closed T15426: PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 11 2023, 14:34 · PHP 8 support
aklapper closed D25258: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed.
Jun 11 2023, 14:34
aklapper closed T15426: PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed as Resolved by committing rP108cbcd09bd3: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with….
Jun 11 2023, 14:34 · PHP 8 support
aklapper committed rP108cbcd09bd3: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with….
Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with…
Jun 11 2023, 14:34
aklapper updated the diff for D25258: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed.

Improve error message, use phutil_nonempty_string instead of null check

Jun 11 2023, 12:20

Jun 10 2023

aklapper closed D25283: Fix PHP 8.1 "strlen(null)" exception initializing Diffusion repository without path access permissions.
Jun 10 2023, 21:00
aklapper closed T15459: PHP 8.1 "strlen(null)" exception initializing Diffusion repository without path access permissions, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 10 2023, 21:00 · PHP 8 support
aklapper closed T15459: PHP 8.1 "strlen(null)" exception initializing Diffusion repository without path access permissions as Resolved by committing rP7b57ba2b982f: Fix PHP 8.1 "strlen(null)" exception initializing Diffusion repository without….
Jun 10 2023, 21:00 · PHP 8 support
aklapper committed rP7b57ba2b982f: Fix PHP 8.1 "strlen(null)" exception initializing Diffusion repository without….
Fix PHP 8.1 "strlen(null)" exception initializing Diffusion repository without…
Jun 10 2023, 21:00
aklapper closed T15413: PHP 8.1 "json_decode(null)" exception blocks creating Almanac Hosts blueprint in Drydock, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 10 2023, 20:58 · PHP 8 support
aklapper closed T15413: PHP 8.1 "json_decode(null)" exception blocks creating Almanac Hosts blueprint in Drydock as Resolved by committing rPc553692d452b: Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create….
Jun 10 2023, 20:58 · PHP 8 support
aklapper closed D25240: Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create Blueprint page.
Jun 10 2023, 20:58
aklapper committed rPc553692d452b: Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create….
Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create…
Jun 10 2023, 20:58
aklapper updated the diff for D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.

Add PHP version check and manually remove deprecated encodings from array to hopefully avoid the unit test failure "Handling Base64 via mbstring is deprecated; use base64_encode/base64_decode instead" though that should only be an issue since PHP 8.2 according to https://php.watch/versions/8.2/mbstring-qprint-base64-uuencode-html-entities-deprecated ? What do I know. :)

Jun 10 2023, 19:10
aklapper updated the diff for D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.

Wrap three lines to be less than 80 characters

Jun 10 2023, 18:57
aklapper updated the diff for D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.

Also handle encoding aliases; Store existing encodings and encoding aliases in array keys so look up is O(1); compare new encoding against existing encodings and encoding aliases both as lower case.

Jun 10 2023, 18:54
aklapper updated the summary of D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.
Jun 10 2023, 18:53
aklapper closed T15379: PHP 8.1 "ltrim(null)" exception blocks rendering first Meme comment, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 10 2023, 16:41 · PHP 8 support
aklapper closed T15379: PHP 8.1 "ltrim(null)" exception blocks rendering first Meme comment as Resolved by committing rPb4cfe56f03b4: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment.
Jun 10 2023, 16:41 · PHP 8 support
aklapper closed D25212: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment.
Jun 10 2023, 16:41
aklapper committed rPb4cfe56f03b4: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment.
Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment
Jun 10 2023, 16:41
aklapper closed D25282: Fix PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page.
Jun 10 2023, 16:34
aklapper closed T15458: PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 10 2023, 16:34 · PHP 8 support
aklapper closed T15458: PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page as Resolved by committing rP76ef9db8a5ed: Fix PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo….
Jun 10 2023, 16:34 · PHP 8 support
aklapper committed rP76ef9db8a5ed: Fix PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo….
Fix PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo…
Jun 10 2023, 16:34
aklapper requested review of D25283: Fix PHP 8.1 "strlen(null)" exception initializing Diffusion repository without path access permissions.
Jun 10 2023, 16:33
aklapper added a revision to T15459: PHP 8.1 "strlen(null)" exception initializing Diffusion repository without path access permissions: D25283: Fix PHP 8.1 "strlen(null)" exception initializing Diffusion repository without path access permissions.
Jun 10 2023, 16:33 · PHP 8 support
aklapper created T15459: PHP 8.1 "strlen(null)" exception initializing Diffusion repository without path access permissions.
Jun 10 2023, 16:31 · PHP 8 support
aklapper updated the summary of D25258: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed.
Jun 10 2023, 15:40
aklapper updated the diff for D25258: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed.

Instead of this change update FileUploadConduitAPIMethod::execute() to check for a null argument, similar to how the other arguments are validated before proceeding

Jun 10 2023, 15:37
aklapper updated the diff for D25240: Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create Blueprint page.

Add an additional null check instead of casting to string

Jun 10 2023, 15:10
aklapper updated the summary of D25240: Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create Blueprint page.
Jun 10 2023, 15:09
aklapper closed T15331: PHP 8.1 "strlen(null)" exceptions block creating a project with an empty Description field, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 10 2023, 14:36 · PHP 8 support
aklapper closed T15331: PHP 8.1 "strlen(null)" exceptions block creating a project with an empty Description field as Resolved.
Jun 10 2023, 14:36 · Projects, Arcanist, PHP 8 support
aklapper closed D25176: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an empty Description field.
Jun 10 2023, 14:35
aklapper committed rARC97e163187418: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an….
Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an…
Jun 10 2023, 14:35
aklapper updated the summary of D25176: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an empty Description field.
Jun 10 2023, 14:34
aklapper closed T15427: PHP 8.1 "trim(null)" exception blocks rendering Conduit's harbormaster.sendmessage page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 10 2023, 14:27 · PHP 8 support
aklapper closed T15427: PHP 8.1 "trim(null)" exception blocks rendering Conduit's harbormaster.sendmessage page as Resolved by committing rPbab997074055: Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's….
Jun 10 2023, 14:26 · PHP 8 support
aklapper closed D25259: Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's harbormaster.sendmessage page.
Jun 10 2023, 14:26
aklapper committed rPbab997074055: Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's….
Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's…
Jun 10 2023, 14:26
aklapper updated the summary of D25282: Fix PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page.
Jun 10 2023, 14:23
aklapper updated the diff for D25282: Fix PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page.

Use null checks instead as we're not sure it's always a string

Jun 10 2023, 14:23
aklapper updated the task description for T15458: PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page.
Jun 10 2023, 14:18 · PHP 8 support
aklapper requested review of D25282: Fix PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page.
Jun 10 2023, 14:15
aklapper added a revision to T15458: PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page: D25282: Fix PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page.
Jun 10 2023, 14:15 · PHP 8 support
aklapper created T15458: PHP 8.1 "strlen(null)" exception about Staging URI on Diffusion repo History page.
Jun 10 2023, 14:10 · PHP 8 support
aklapper updated the diff for D25259: Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's harbormaster.sendmessage page.

Simplify logic; use null check instead

Jun 10 2023, 11:09

Jun 9 2023

aklapper updated the test plan for D25281: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an empty Inline Comment).
Jun 9 2023, 19:03
aklapper requested review of D25281: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an empty Inline Comment).
Jun 9 2023, 18:55
aklapper added a revision to T15456: Pholio: RuntimeException: Undefined variable $dictionary when adding an empty Inline Comment: D25281: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an empty Inline Comment).
Jun 9 2023, 18:55
aklapper created T15456: Pholio: RuntimeException: Undefined variable $dictionary when adding an empty Inline Comment.
Jun 9 2023, 18:50

Jun 8 2023

aklapper added a comment to T15125: Unknown edge constant "26"! when deleting a file with old attachment edges.

For the records, I had the same experience when deleting a repository via ./bin/remove destroy rESHP for Unknown edge constant "25" (not 26 as mentioned in the task title) in downstream https://phabricator.wikimedia.org/T119588

Jun 8 2023, 16:46 · Affects-Wikimedia, Files, Bug Reports
aklapper requested review of D25280: Fix some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page.
Jun 8 2023, 14:51
aklapper added a revision to T15454: Some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page: D25280: Fix some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page.
Jun 8 2023, 14:51
aklapper created T15454: Some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page.
Jun 8 2023, 14:50
aklapper closed T15445: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import Only", a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 8 2023, 12:53 · PHP 8 support
aklapper closed D25277: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import Only".
Jun 8 2023, 12:53
aklapper closed T15445: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import Only" as Resolved by committing rP7af82abcb908: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import….
Jun 8 2023, 12:53 · PHP 8 support
aklapper committed rP7af82abcb908: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import….
PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import…
Jun 8 2023, 12:53
aklapper closed T15440: PHP 8.1 strlen(null) and mb_detect_encoding(null) exceptions creating a Diffusion Identity without entering assignee, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 8 2023, 12:52 · PHP 8 support
aklapper closed T15440: PHP 8.1 strlen(null) and mb_detect_encoding(null) exceptions creating a Diffusion Identity without entering assignee as Resolved by committing rPb09471d55748: Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without….
Jun 8 2023, 12:52 · PHP 8 support
aklapper closed D25271: Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without entering assignee.
Jun 8 2023, 12:52
aklapper committed rPb09471d55748: Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without….
Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without…
Jun 8 2023, 12:52
aklapper closed T15434: PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 8 2023, 12:50 · PHP 8 support
aklapper closed T15434: PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch as Resolved by committing rP9aa88ae0d7d4: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after….
Jun 8 2023, 12:50 · PHP 8 support
aklapper closed D25265: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch.
Jun 8 2023, 12:50
aklapper committed rP9aa88ae0d7d4: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after….
Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after…
Jun 8 2023, 12:50
aklapper closed T15432: PHP 8.1 "strlen(null)" exceptions block rendering Differential Revision page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 8 2023, 12:49 · PHP 8 support
aklapper closed T15432: PHP 8.1 "strlen(null)" exceptions block rendering Differential Revision page as Resolved by committing rP25c4f6224d63: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.
Jun 8 2023, 12:49 · PHP 8 support
aklapper closed D25264: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.
Jun 8 2023, 12:49
aklapper committed rP25c4f6224d63: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.
Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page
Jun 8 2023, 12:49
aklapper closed T15431: PHP 8.1 "preg_match(null)" exception blocks rendering "Create Revision" page in Differential, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 8 2023, 12:48 · PHP 8 support
aklapper closed D25263: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in Differential when not entering data.
Jun 8 2023, 12:48
aklapper closed T15431: PHP 8.1 "preg_match(null)" exception blocks rendering "Create Revision" page in Differential as Resolved by committing rP44a8a1c408ed: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in….
Jun 8 2023, 12:48 · PHP 8 support
aklapper committed rP44a8a1c408ed: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in….
Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in…
Jun 8 2023, 12:48
aklapper updated the diff for D25277: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import Only".

Check for === null instead of using phutil_nonempty_string; check both $old and $new

Jun 8 2023, 10:44
aklapper updated the diff for D25271: Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without entering assignee.

Use a null-check instead of assuming it's a string

Jun 8 2023, 10:16
aklapper updated the diff for D25264: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.

Simplify changes as proposed by speck

Jun 8 2023, 10:14
aklapper updated the diff for D25265: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch.

Also pass $new to phutil_nonempty_string() and not only $old.
I'm not convinced that we should check $new and $old for === null here instead of using phutil_nonempty_string(). But of course you make the final decision.

Jun 8 2023, 09:57
aklapper updated the diff for D25263: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in Differential when not entering data.

Update change to be consistent with https://we.phorge.it/D25268#change-HsYn5r9Vm2Ju

Jun 8 2023, 09:53