Paths

Table of Contentst

-
src/applications/diffusion/conduit/
-
applications/
-
diffusion/
-
conduit/
-
DiffusionHistoryQueryConduitAPIMethod.php

Differential D25287

Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history
ClosedPublic
Actions

Authored by aklapper on Jun 12 2023, 00:34.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15463: PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history

Commits

rP9b99123ff931: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=diffusionBrowseCode, ref.master=108cbcd09bd3, ref.diffusionBrowseCode=015ffef14b0c)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php:50]

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=diffusionBrowseCode, ref.master=108cbcd09bd3, ref.diffusionBrowseCode=015ffef14b0c)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php:50]

Closes T15463

Test Plan

After applying these two changes, get next expected exceptions about RuntimeException: file_exists(): Passing null to parameter #1 ($filename) of type string is deprecated and CommandException: Command failed with error #128! fatal: detected dubious ownership in repository at '/var/repo/1', but no RuntimeException about strlen() anymore.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jun 12 2023, 00:34

Owners added a reviewer: O1: Blessed Committers.Jun 12 2023, 00:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJun 12 2023, 00:34

aklapper requested review of this revision.Jun 12 2023, 00:34

Harbormaster completed remote builds in B539: Diff 934.Jun 12 2023, 00:34

speck accepted this revision.Jun 12 2023, 00:44

This revision is now accepted and ready to land.Jun 12 2023, 00:44

Closed by commit rP9b99123ff931: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository…. · Explain WhyJun 12 2023, 00:51

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP9b99123ff931: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

conduit/

DiffusionHistoryQueryConduitAPIMethod.php

4 lines

O1: Blessed Committers

Diff 935

View Options

src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines	if ($object->isChangePlanned()) {
'You can not request review of this revision because this '.		'You can not request review of this revision because this '.
'revision is already under review and the action would have '.		'revision is already under review and the action would have '.
'no effect.'));		'no effect.'));
}		}

if ($object->isClosed()) {		if ($object->isClosed()) {
throw new Exception(		throw new Exception(
pht(		pht(
'You can not plan changes to this this revision because it has '.		'You can not plan changes to this revision because it has '.
		valerio.bozzolanUnsubmitted Done Inline Actions ✅ I verified this line with my big eyes valerio.bozzolan: ✅ I verified this line with my big eyes
'already been closed.'));		'already been closed.'));
}		}

if (!$this->isViewerRevisionAuthor($object, $viewer)) {		if (!$this->isViewerRevisionAuthor($object, $viewer)) {
throw new Exception(		throw new Exception(
pht(		pht(
'You can not plan changes to this revision because you do not '.		'You can not plan changes to this revision because you do not '.
'own it. Only the author of a revision can plan changes to it.'));		'own it. Only the author of a revision can plan changes to it.'));
Show All 36 Lines

Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository historyClosedPublicActions