This revision allows us to see where passphrase credentials are mentioned in other parts of phabricator
This is very useful to "What is this credential for?" If we can see where it was been mentioned
Details
Details
- Reviewers
Matthew - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15234: Support Mentions in Passphrase
- Commits
- rP4aedc206c727: Update PassphraseCredential to support Mentions
Mentioned a passphrase and saw it in the transaction list
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- lc-phorge-master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 60 Build 60: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 967 ms | PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`.
These entries differ: xmap.PassphraseCredential.4, xmap.PassphraseCredential.5, xmap.PassphraseCredential.6, xmap.PassphraseCredential.7, xmap.PassphraseCredential.8, xmap.PassphraseCredential.9.
| |
| 949 ms | PhabricatorCelerityTestCase::testCelerityMaps 1 assertion passed. | |
| 1,571 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 316 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed. | |
| 345 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed. | |
| View Full Test Results (1 Failed · 6 Passed) |
