Co-Author support in arc land T15044
Needs RevisionPublic
Actions

Authored by TitanNano on Dec 1 2021, 10:55.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15044: Co-Author support in arc land

Summary

This adds all additional commit authors to the differential commit message as co-authors.
I'm not yet done with this, but it's a first draft. I would like to also extend commit parsing so we store,
co-author lines from the original commits. Once we have that we can add them as well.

Diff Detail

Repository

rP Phorge

Branch

issues/T15044

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 59
Build 59: arc lint + arc unit

Event Timeline

TitanNano created this revision.Dec 1 2021, 10:55

TitanNano held this revision as a draft.

Owners added a reviewer: O1: Blessed Committers.Dec 1 2021, 10:55

Herald added subscribers: valerio.bozzolan, tobiaswiese, speck. · View Herald TranscriptDec 1 2021, 10:55

Harbormaster completed remote builds in B55: Diff 77.Dec 1 2021, 10:55

include co-author data from local commits

Harbormaster completed remote builds in B59: Diff 81.Dec 3 2021, 08:58

TitanNano published this revision for review.Dec 3 2021, 09:00

TitanNano edited the summary of this revision. (Show Details)Dec 3 2021, 09:03

avivey subscribed.Dec 18 2021, 07:25

avivey added inline comments.

src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php
125	Can we have the `Co-authored-by` title as the `label` for the field, and let this field go through the regular code-path her (the `else`)? I'd like to avoid special cases as much as possible, to allow more extensions - ideally, I want installs to be able to add other footers based on the same logic as custom extensions. That probably means we need to allow (1) multiple instances of the same `CommitMessageField` and (2) make sure we somehow control the order of fields in `$field_list` (which we might already do? It looks like something is forcing `title` to be first).