We have to parse the commit messages and add all co-authors to the "local:commits"
diff property, so we can use it later during arc land.
See also D25028.
Details
Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15044: Co-Author support in arc land
- create a commit with one or more "Co-authored-by" lines.
- arc diff the commit into a revision
- verify that the local:commits property contains a coAuthors array with all co-authors
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- issues/T15044
- Lint
Lint Errors Severity Location Code Message Error src/repository/api/ArcanistGitAPI.php:194 XHP23 Reuse of Iterator Variable Warning src/repository/api/ArcanistGitAPI.php:195 XHP36 Slow Construct Warning src/repository/api/ArcanistGitAPI.php:200 TXT3 Line Too Long Warning src/repository/api/ArcanistMercurialAPI.php:229 XHP36 Slow Construct Warning src/repository/api/ArcanistMercurialAPI.php:234 TXT3 Line Too Long Advice src/repository/api/ArcanistMercurialAPI.php:258 XHP48 Array Separator - Unit
Tests Passed - Build Status
Buildable 56 Build 56: arc lint + arc unit
Event Timeline
| src/repository/api/ArcanistGitAPI.php | ||
|---|---|---|
| 221 | Looks like we already upload the entire commit message - can we do this logic in the server, avoiding adding this key to the API? | |