Page MenuHomePhorge

Remarkup: minor refactor to identify anchor and relative URIs
AbandonedPublic

Authored by valerio.bozzolan on Mar 23 2023, 09:20.
Tags
None
Referenced Files
F3850639: D25082.1746115664.diff
Wed, Apr 30, 16:07
F3775075: D25082.1745857898.diff
Sun, Apr 27, 16:31
F3769541: D25082.1745852167.diff
Sun, Apr 27, 14:56
F3763417: D25082.1745839260.diff
Sun, Apr 27, 11:21
F3762272: D25082.1745832750.diff
Sun, Apr 27, 09:32
F3754586: D25082.1745820037.diff
Sun, Apr 27, 06:00
F3746362: D25082.1745768056.diff
Sat, Apr 26, 15:34
F3553624: D25082.1744947320.diff
Thu, Apr 17, 03:35

Details

Summary

This modification should not change anything logically.

This change simplifies these checks:

  • identify an anchor
  • identify a relative URI

https://we.phorge.it/T15182

The methods are introduced in PhutilRemarkupRule since that
is the parent class of these children classes:

  • PhutilRemarkupDocumentLinkRule
  • PhutilRemarkupHyperlinkRule

Ref T15182

Test Plan
  • Just check that nothing has been changed logically

Diff Detail

Repository
rP Phorge
Branch
T15161-remarkup-internal-links-refactor
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/infrastructure/markup/markuprule/PhutilRemarkupRule.php:115XHP25Spaces Inside Parentheses
Warningsrc/infrastructure/markup/markuprule/PhutilRemarkupRule.php:125XHP25Spaces Inside Parentheses
Unit
Test Failures
Build Status
Buildable 153
Build 153: arc lint + arc unit

Unit TestsFailed

TimeTest
755 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
81 msPhabricatorAnchorTestCase::testAnchors
8 assertions passed.
1,065 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
407 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
355 msPhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
1 assertion passed.
View Full Test Results (1 Failed · 21 Passed · 1 Skipped)

Event Timeline