Page MenuHomePhorge

Remove unused feed/feed.css and maniphest/task-edit.css
ClosedPublic

Authored by aklapper on Fri, May 2, 13:32.
Tags
None
Referenced Files
F4278891: D25985.1747378969.diff
Thu, May 15, 07:02
F4249017: D25985.1747279621.diff
Wed, May 14, 03:27
F4221818: D25985.1747238806.diff
Tue, May 13, 16:06
F4196031: D25985.1747203196.diff
Tue, May 13, 06:13
F4180470: D25985.1747128246.diff
Mon, May 12, 09:24
F4045348: D25985.1746732861.diff
Wed, May 7, 19:34
F4033359: D25985.1746713440.diff
Wed, May 7, 14:10
F3991180: D25985.1746591472.diff
Tue, May 6, 04:17

Details

Summary

Note: This is always a bit dangerous because of some concatenation like 'class' => 'toggle'.$more in the codebase.

Test Plan

Grep the code for the parent CSS selector, also doing a partial search. Example:

$ grep --exclude="*.css" -R 'feed-newer-link' .
$ grep --exclude="*.css" -R 'feed-older-link' .
$ grep --exclude="*.css" -R 'public-feed-frame ' .
$ grep --exclude="*.css" -R 'auxiliary-header' .

No results.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper requested review of this revision.Fri, May 2, 13:32
valerio.bozzolan edited the test plan for this revision. (Show Details)

Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaanks

This revision is now accepted and ready to land.Wed, May 7, 16:21
aklapper retitled this revision from Remove some unused CSS files to Remove unused CSS files feed/feed.css and maniphest/task-edit.css.Wed, May 7, 23:10
aklapper retitled this revision from Remove unused CSS files feed/feed.css and maniphest/task-edit.css to Remove unused feed/feed.css and maniphest/task-edit.css.Thu, May 8, 12:21