Page MenuHomePhorge
Differential D25959

Simplify project regex further
ClosedPublic
Actions

Authored by pppery on Fri, Apr 11, 15:27.
Tags
None
Referenced Files
F3867195: D25959.1746185355.diff
Thu, May 1, 11:29
F3851347: D25959.1746119175.diff
Wed, Apr 30, 17:06
F3749129: D25959.1745790661.diff
Sat, Apr 26, 21:51
F3749128: D25959.1745790660.diff
Sat, Apr 26, 21:51
F3749127: D25959.1745790659.diff
Sat, Apr 26, 21:50
F3749126: D25959.1745790658.diff
Sat, Apr 26, 21:50
F3709364: D25959.1745649364.diff
Fri, Apr 25, 06:36
F3686780: D25959.1745585954.diff
Thu, Apr 24, 12:59
View All 44 Files
Subscribers
bekay
Cigaryno
mainframe98
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
aklapper
bekay
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T16028: New project remarkup rule misses some project names
Commits
rP4bd591e4414b: Simplify project regex further
Summary

Fixes T16028

Test Plan

Assert that #js-draw-lib (or any other project name with one or two characters followed by a non-word) links correctly. It was previously parsed as #js -draw-lib.

Repeat the test plan for D25838 and observe it still works

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1892
Build 1892: arc lint + arc unit

Event Timeline

pppery created this revision.Fri, Apr 11, 15:27
Owners added a reviewer: O1: Blessed Committers.Fri, Apr 11, 15:27
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Apr 11, 15:27
pppery requested review of this revision.Fri, Apr 11, 15:27
Harbormaster completed remote builds in B1860: Diff 2862.Fri, Apr 11, 15:27
valerio.bozzolan added a comment.Fri, Apr 11, 15:33

Wow, super fast thanks. Maybe nice to expand a bit the src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

pppery updated this revision to Diff 2863.Fri, Apr 11, 17:38

Add test

Harbormaster completed remote builds in B1861: Diff 2863.Fri, Apr 11, 17:38
pppery updated this revision to Diff 2864.Fri, Apr 11, 17:41

Fix

Harbormaster completed remote builds in B1862: Diff 2864.Fri, Apr 11, 17:41
bekay accepted this revision.Mon, Apr 14, 08:01
bekay subscribed.

Works for me. Tested on our firm instance.

valerio.bozzolan accepted this revision.Fri, Apr 25, 09:47

Thanks! also for the freshly added unit test :3 :3

makeitso

This revision is now accepted and ready to land.Fri, Apr 25, 09:47
mainframe98 subscribed.Fri, Apr 25, 11:23
mainframe98 added inline comments.
src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
152

(Odd that the linter did not complain about this)

pppery updated this revision to Diff 2921.Fri, Apr 25, 15:37

Whitespace

Harbormaster completed remote builds in B1892: Diff 2921.Fri, Apr 25, 15:37
pppery marked an inline comment as done.Fri, Apr 25, 15:38
Closed by commit rP4bd591e4414b: Simplify project regex further. · Explain WhyFri, Apr 25, 15:39
This revision was automatically updated to reflect the committed changes.
pppery added a commit: rP4bd591e4414b: Simplify project regex further.

Revision Contents
Changeset List

PathSizePackages
src/
applications/
project/
remarkup/
7 linesO1: Blessed Committers
__tests__/
15 linesO1: Blessed Committers

Diff 2921

View Options

src/applications/project/remarkup/ProjectRemarkupRule.php

Loading...
View Options

src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0