Paths

Table of Contentst

Simplify project regex further
Needs ReviewPublic
Actions

Authored by pppery on Fri, Apr 11, 15:27.

Tags

None

Referenced Files

	F3532432: D25959.1744890800.diff
	Wed, Apr 16, 11:53

	F3530812: D25959.1744876390.diff
	Wed, Apr 16, 07:53

	F3530213: D25959.1744872173.diff
	Wed, Apr 16, 06:42

	F3530202: D25959.1744871896.diff
	Wed, Apr 16, 06:38

	F3530198: D25959.1744871806.diff
	Wed, Apr 16, 06:36

	F3511640: D25959.1744805767.diff
	Tue, Apr 15, 12:16

	F3453538: D25959.1744722442.diff
	Mon, Apr 14, 13:07

	F3441746: D25959.1744693310.diff
	Mon, Apr 14, 05:01

Subscribers

Details

Reviewers

aklapper
bekay

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16028: New project remarkup rule misses some project names

Summary

Fixes T16028

Test Plan

Assert that #js-draw-lib (or any other project name with one or two characters followed by a non-word) links correctly. It was previously parsed as #js -draw-lib.

Repeat the test plan for D25838 and observe it still works

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1862
Build 1862: arc lint + arc unit

Event Timeline

pppery created this revision.Fri, Apr 11, 15:27

Owners added a reviewer: O1: Blessed Committers.Fri, Apr 11, 15:27

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Apr 11, 15:27

pppery requested review of this revision.Fri, Apr 11, 15:27

Harbormaster completed remote builds in B1860: Diff 2862.Fri, Apr 11, 15:27

Wow, super fast thanks. Maybe nice to expand a bit the src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

Add test

Harbormaster completed remote builds in B1861: Diff 2863.Fri, Apr 11, 17:38

Fix

Harbormaster completed remote builds in B1862: Diff 2864.Fri, Apr 11, 17:41

Works for me. Tested on our firm instance.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

project/

remarkup/

ProjectRemarkupRule.php

7 lines

O1: Blessed Committers

__tests__/

ProjectRemarkupRuleTestCase.php

15 lines

O1: Blessed Committers

Diff 2864

View Options

src/applications/project/remarkup/ProjectRemarkupRule.php

View Options

src/applications/project/remarkup/tests/ProjectRemarkupRuleTestCase.php

Simplify project regex furtherNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2864

src/applications/project/remarkup/ProjectRemarkupRule.php

src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

Simplify project regex further
Needs ReviewPublic
Actions

Revision Contents
Changeset List

src/applications/project/remarkup/tests/ProjectRemarkupRuleTestCase.php