Fixes T16028
Details
Details
- Reviewers
aklapper bekay valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T16028: New project remarkup rule misses some project names
- Commits
- rP4bd591e4414b: Simplify project regex further
Assert that #js-draw-lib (or any other project name with one or two characters followed by a non-word) links correctly. It was previously parsed as #js -draw-lib.
Repeat the test plan for D25838 and observe it still works
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- master
- Lint
Lint Errors Severity Location Code Message Error src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php:139 TXT2 Tab Literal Advice src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php:142 XHP48 Array Separator Advice src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php:148 XHP48 Array Separator - Unit
Test Failures - Build Status
Buildable 1861 Build 1861: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 5 ms | ProjectRemarkupRuleTestCase::testProjectObjectRemarkup Assertion failed, expected values to be equal (at ProjectRemarkupRuleTestCase.php:155): #js-draw
Expected vs Actual Output Diff
--- Old Value
| |
| 79 ms | PhabricatorCelerityTestCase::testCelerityMaps 1 assertion passed. | |
| 7 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 0 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed. | |
| 1 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed. | |
| View Full Test Results (1 Failed · 30 Passed) |
Event Timeline
Comment Actions
Wow, super fast thanks. Maybe nice to expand a bit the src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
| src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php | ||
|---|---|---|
| 152 | (Odd that the linter did not complain about this) | |