This extension was deprecated in PHP 5.5.0 and removed in PHP 7.0.0.
Given the requirement of PHP 7.2, it makes no sense to support this
extension.
Closes T16024
Details
Details
- Reviewers
aklapper - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T16024: Tech Debt: Remove PHP mysql extension related code
- Commits
- rP0f7e76ffe4f2: Remove support for PHP mysql extension
Grep for both mysql and mysqli and look for outdated references.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T16024-remove-mysql-related-code
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1845 Build 1845: arc lint + arc unit
Event Timeline
Comment Actions
Nearly perfect (thanks!), only thing missing is to also update mysql (or mysqli) in src/docs/user/installation_guide.diviner.
Also no clue whether to add an array item to PhabricatorExtensionsSetupCheck::executeChecks().
Probably not, running php -m on my machine lists items like mysqli and mysqlnd and pdo_mysql plus the docs tell people to have mysqli.
Comment Actions
- Apply this patch on a Fedora 42 system with PHP 8.4.5. php -m listed mysqli, mysqlnd, pdo_mysql etc.
- Uninstall php-mysqlnd package. After reboot, php -m does not list those three modules anymore, and Phorge complains Required PHP extensions are not installed: mysqli as expected.
- Install package again, Phorge works: "Unresolved setup issues" still lists the same MySQL related stuff as before; /config/clusters/databases shows entry as usual; successfully filed a Maniphest task.
- Open /etc/php.ini and set mysqli.allow_local_infile = On. Restart Apache HTTPD. "Unresolved setup issues" in Phorge shows Unsafe "MySQL "local_infile" Setting Enabled as expected.