Page MenuHomePhorge

Remove support for PHP mysql extension
Needs ReviewPublic

Authored by mainframe98 on Sat, Apr 5, 12:03.

Details

Summary

This extension was deprecated in PHP 5.5.0 and removed in PHP 7.0.0.
Given the requirement of PHP 7.2, it makes no sense to support this
extension.

Closes T16024

Test Plan

Grep for both mysql and mysqli and look for outdated references.

Diff Detail

Repository
rP Phorge
Branch
T16024-remove-mysql-related-code
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1845
Build 1845: arc lint + arc unit

Event Timeline

mainframe98 updated this revision to Diff 2833.

Ran bin/celerity map

aklapper requested changes to this revision.Sat, Apr 5, 13:12
aklapper subscribed.

Nearly perfect (thanks!), only thing missing is to also update mysql (or mysqli) in src/docs/user/installation_guide.diviner.

Also no clue whether to add an array item to PhabricatorExtensionsSetupCheck::executeChecks().
Probably not, running php -m on my machine lists items like mysqli and mysqlnd and pdo_mysql plus the docs tell people to have mysqli.

This revision now requires changes to proceed.Sat, Apr 5, 13:12

Update documentation and simplify extension check