This extension was deprecated in PHP 5.5.0 and removed in PHP 7.0.0.
Given the requirement of PHP 7.2, it makes no sense to support this
extension.
Closes T16024
Details
Details
- Reviewers
aklapper - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T16024: Tech Debt: Remove PHP mysql extension related code
Grep for both mysql and mysqli and look for outdated references.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T16024-remove-mysql-related-code
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 1840 Build 1840: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 642 ms | PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:27): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it.
ACTUAL VALUE
| |
| 536 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 291 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed. | |
| 292 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed. | |
| 313 ms | PhabricatorLibraryTestCase::testEverythingImplemented 1 assertion passed. | |
| View Full Test Results (1 Failed · 7 Passed) |
Event Timeline
Comment Actions
Nearly perfect (thanks!), only thing missing is to also update mysql (or mysqli) in src/docs/user/installation_guide.diviner.
Also no clue whether to add an array item to PhabricatorExtensionsSetupCheck::executeChecks().
Probably not, running php -m on my machine lists items like mysqli and mysqlnd and pdo_mysql plus the docs tell people to have mysqli.