Page MenuHomePhorge

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic

Authored by aklapper on Aug 31 2024, 12:43.

Details

Summary

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

This patch is a followup on top of D25814.

Refs T15935

Test Plan
  • Try to view a task in the browser
  • Try to run ./bin/auth recover on the CLI
  • Try to browse projects in the browser
  • Try to create a new project without a name in the browser

Diff Detail

Repository
rP Phorge
Branch
T15935php84part2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1586
Build 1586: arc lint + arc unit

Event Timeline

aklapper edited the test plan for this revision. (Show Details)
aklapper edited the test plan for this revision. (Show Details)

Moah fixees

This revision is now accepted and ready to land.Oct 18 2024, 12:52