Paths

Table of Contentst

Differential D25491

Improve contrast of Links in Dark Mode
AcceptedPublic
Actions

Authored by deric on Dec 6 2023, 16:30.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15056: Improve Dark Mode

Summary

Use lighter color (higher contrast to dark background) in Links in Dark Mode.

Before	After

Explanation:

Screenshot_20231206_173817.png (492×627 px, 58 KB)

Ref T15056

Test Plan

Flush all Phorge caches
Sign in
Go to user's Settings > Display Preferences and select the Accessibility (user interface) "Dark Mode".
Check Dashboard links
Check People lists
Check Maniphest lists
Check Diffusion lists
Check Feeds, etc.

Diff Detail

Repository

rP Phorge

Branch

theme

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 972
Build 972: arc lint + arc unit

Event Timeline

deric created this revision.Dec 6 2023, 16:30

Owners added 1 blocking reviewer(s): O1: Blessed Committers.Dec 6 2023, 16:30

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 6 2023, 16:30

deric requested review of this revision.Dec 6 2023, 16:30

Harbormaster completed remote builds in B972: Diff 1569.Dec 6 2023, 16:30

deric edited the summary of this revision. (Show Details)Dec 6 2023, 16:41

valerio.bozzolan retitled this revision from Links in dark theme have low contrast (T15056) to Improve contrast of Links in Dark Mode.Dec 6 2023, 19:33

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan added a task: T15056: Improve Dark Mode.

arc lint

arc unit

Harbormaster completed remote builds in B976: Diff 1575.Dec 6 2023, 19:36

Tested, thanks! no nuclear implosions and I like it. I also think that "accadf" is more readable than before :^) please wait some days before landing to eventually attract additional testers.

This revision is now accepted and ready to land.Dec 6 2023, 19:36

Hi deric,

To land this change, please try these:

arc patch D25491
arc land

Or use ../arcanist/bin/arc

Thanks

@deric: Hi, would you like to arc land your patch, or do you need any help? Thanks in advance!

@aklapper Yeah, that would be great. Sorry, I don't have a working dev instance right now.

Hello! Are you sure changing the links color is a good idea? Perhaps we should just make the background darker?

In D25491#15482, @Iniquity wrote:

Hello! Are you sure changing the links color is a good idea? Perhaps we should just make the background darker?

I actually think a darker background and lighter link color would be good. Maybe not quite as light as #accadf, perhaps #46B2FF or so

In D25491#15484, @20after4 wrote:

In D25491#15482, @Iniquity wrote:

Hello! Are you sure changing the links color is a good idea? Perhaps we should just make the background darker?

I actually think a darker background and lighter link color would be good. Maybe not quite as light as #accadf, perhaps #46B2FF or so

I like #46b2ff color too :)

20after4 mentioned this in T15744: Render html color codes in remarkup.Feb 25 2024, 00:53

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

celerity/

postprocessor/

CelerityDarkModePostprocessor.php

2 lines

O1: Blessed Committers

Diff 1569

View Options

src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php

Improve contrast of Links in Dark ModeAcceptedPublicActions