Updated .arcconfig to we.phorge.it
Refs T15006
I would also note, I created this revision using the container setup developed by @willson556 mentioned in T15011#370 and it worked great!
Details
Details
- Reviewers
speck avivey tobiaswiese eax - Group Reviewers
O1: Blessed Committers Blessed Committers - Maniphest Tasks
- T15006: Re-brand Phorge
- Commits
- rARCcf4b14fcbf22: Arcanist Update .arcconfig to point to we.phorge.it
Ran arc install-certificate and was able to get token from the right place and install it
Ran arc which saw that it identified we.phorge.it
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- arcpatch-D25003
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 13 Build 13: arc lint + arc unit
Event Timeline
Comment Actions
This and D25001: T15006: Update .arcconfig to point to we.phorge.it are duplicates. I tried to land it this morning but ran into issues with the land process that I didn't have time to work out
Comment Actions
@speck @avivey Can you add me as a Blessed Committers ??
I think I need that to land this revision
Comment Actions
@Ekubischta it looks like @chris added you - could you verify your email? I'm also thinking anyone in the "security" or "blessed" groups should turn on MFA as well.
Comment Actions
I added a 2nd email (gmail) because my corp email can't receive anything from here it seems - I have tried to verify a number of times with no luck
Comment Actions
hmm - I cannot land this revision?
Here is the herald transcript https://we.phorge.it/herald/transcript/500/
Output of arc land
root@da45f51c0605:/srv/phorge/arcanist# arc land
STRATEGY Merging with "squash" strategy, the default strategy.
SOURCE Landing the current branch, "arcpatch-D25003".
ONTO REMOTE Landing onto remote "origin", the default remote under Git.
ONTO TARGET Landing onto target "master", the default target under Git.
INTO REMOTE Will merge into remote "origin" by default, because this is the remote the change is landing onto.
INTO TARGET Will merge into target "master" by default, because this is the "onto" target.
FETCH Fetching "master" from remote "origin"...
$ git fetch --no-tags --quiet -- origin master
INTO COMMIT Preparing merge into "master" from remote "origin", at commit "246e604a070f".
LANDING These changes will land:
* D25003 Arcanist Update .arcconfig to point to we.phorge.it
4029a8117b8d Arcanist Update .arcconfig to point to we.phorge.it
>>> Land these changes? [y/N/?] y
MERGING 4029a8117b8d Arcanist Update .arcconfig to point to we.phorge.it
MERGE Attempting to rebase changes.
DONE Merge succeeded.
PUSHING Pushing changes to "origin".
$ git push -- origin 0b84a643f74a:refs/heads/master
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 710 bytes | 710.00 KiB/s, done.
Total 3 (delta 1), reused 0 (delta 0)
remote: +---------------------------------------------------------------+
remote: | * * * PUSH REJECTED BY EVIL DRAGON BUREAUCRATS * * * |
remote: +---------------------------------------------------------------+
remote: \
remote: \ ^ /^
remote: \ / \ // \
remote: \ |\___/| / \// .\
remote: \ /V V \__ / // | \ \ *----*
remote: / / \/_/ // | \ \ \ |
remote: @___@` \/_ // | \ \ \/\ \
remote: 0/0/| \/_ // | \ \ \ \
remote: 0/0/0/0/| \/// | \ \ | |
remote: 0/0/0/0/0/_|_ / ( // | \ _\ | /
remote: 0/0/0/0/0/0/`/,_ _ _/ ) ; -. | _ _\.-~ / /
remote: ,-} _ *-.|.-~-. .~ ~
remote: * \__/ `/\ / ~-. _ .-~ /
remote: \____(Oo) *. } { /
remote: ( (..) .----~-.\ \-` .~
remote: //___\\ \ DENIED! ///.----..< \ _ -~
remote: // \\ ///-._ _ _ _ _ _ _{^ - - - - ~
remote:
remote:
remote: This push was rejected by Herald push rule H8.
remote: Change: commit/
remote: Rule: Guard Arcanist Repo with Blessed Committers
remote: Reason: Commit is not approved by Blessed Committers
remote: Transcript: https://we.phorge.it/herald/transcript/500/
remote:
To ssh://we.phorge.it/source/arcanist.git
! [remote rejected] 0b84a643f74a -> master (pre-receive hook declined)
error: failed to push some refs to 'ssh://git@we.phorge.it/source/arcanist.git'
LOAD STATE Restoring local state (to ref "arcpatch-D25003" at commit "4029a8117b8d").
USAGE EXCEPTION Push failed! Fix the error and run "arc land" again.Comment Actions
The way we've been going at it on our side what to put an herald rule saying that the diff should be accepted to be landed. The owner system already ensures that someone who has ownership needs to accept the the diff to e considered "accepted".
Comment Actions
Wouldn’t the owners package only cause revisions to be marked, but wouldn’t that leave non-revision commits t not be handled? The herald rules act upon incoming commits rather than ensuring every revision is reviewed.