Page MenuHomePhorge

Calendar: fix creation of ICS Files
ClosedPublic

Authored by valerio.bozzolan on Oct 13 2023, 16:26.

Details

Summary

It seems that, in an attempt to make ICS URI(s) editable, we broke the ability
to manually import ICS files. Whops.

The cause is, the URI needs to be put inside its dedicated import engine,
and not the general one.

Since the intention of T15137 was to be able to edit this field, we have done
that in the right way this time. So, you see the field, not just in creation mode.

Thanks to the kind aklapper for reporting.

Ref T15137
Closes T15619
Rollback 02a4f8b0c8f1279fc0040ad8077942fd8b0d948b

Test Plan
  • visit /calendar/import/ and:
  • create/edit an ICS File Import (now works again)
  • create/edit an ICS URI Import (still work)
  • try looking at an "ICS Import page" as author (URI still visible)
  • try looking at an "ICS Import page" without Edit permissions (URI still omitted correctly)

Diff Detail

Repository
rP Phorge
Branch
fix-ics-file-import
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 866
Build 866: arc lint + arc unit

Event Timeline

After applying this patch locally, after selecting Import .ics file, I can confirm that /calendar/import/edit/ does not show an URI field anymore, and that selecting an ICS File and importing it successfully creates calendar/import/8/ with expected name, date, and time.

Ah, sorry @20after4 if I broke "your" Wikimedia Phabricator ihih

This patch seems to fix, as tested by aklapper

This revision is now accepted and ready to land.Oct 25 2023, 11:56