Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15623: RuntimeException: min(): Array must contain at least one element at DiffusionBlameController.php:201

Commits

rPbeec08e01913: Fix RuntimeException: min(): Array must contain at least one element

Summary

Make sure that $epochs[] is never empty but contains 0 so min($epochs) will not complain.

Closes T15623

Test Plan

Carefully read the code (as I am unaware of reproduction steps).

Diff Detail

Repository

rP Phorge

Branch

T15623min (branched from master)

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 799
Build 799: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,517 ms	PhabricatorLibraryTestCase::testEverythingImplemented EXCEPTION (Exception): Source file "/var/www/html/phorge/phorge/src/applications/project/xaction/PhabricatorProjectDescriptionTransaction.php" failed to load. #0 /var/www/html/phorge/arcanist/src/init/lib/PhutilBootloader.php(211): PhutilBootloader->executeInclude('...') #1 /var/www/html/phorge/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('...', '...')
	243 ms	PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:45): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: class.PhabricatorProjectDescriptionTransaction, xmap.PhabricatorProjectDescriptionTransaction.
	4 ms	PhabricatorLibraryTestCase::testMethodVisibility EXCEPTION (Exception): Source file "/var/www/html/phorge/phorge/src/applications/project/xaction/PhabricatorProjectDescriptionTransaction.php" failed to load. #0 /var/www/html/phorge/arcanist/src/init/lib/PhutilBootloader.php(211): PhutilBootloader->executeInclude('...') #1 /var/www/html/phorge/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('...', '...')
	3 ms	DiffusionServeControllerTestCase::testHandleRequest 2 assertions passed.
	147 ms	PhabricatorCelerityTestCase::testCelerityMaps 1 assertion passed.
		View Full Test Results (3 Failed · 5 Passed)

Event Timeline

aklapper created this revision.Aug 22 2023, 09:09

Owners added a reviewer: O1: Blessed Committers.Aug 22 2023, 09:09

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 22 2023, 09:09

aklapper requested review of this revision.Aug 22 2023, 09:09

Harbormaster completed remote builds in B797: Diff 1320.Aug 22 2023, 09:09

Obviously not a clean tree, sorry. Thus ran arc liberate, now arc asked whether to include unstaged changes in src/__phutil_library_map__.php (yes)

Harbormaster completed remote builds in B798: Diff 1321.Aug 22 2023, 09:13

and that's now wrong because src/__phutil_library_map__.php includes a non-existing file though I had ran git stash. I love git...