Page MenuHomePhorge

Fix RuntimeException: min(): Array must contain at least one element
ClosedPublic

Authored by aklapper on Aug 22 2023, 09:09.

Details

Summary

Make sure that $epochs[] is never empty but contains 0 so min($epochs) will not complain.

Closes T15623

Test Plan

Carefully read the code (as I am unaware of reproduction steps).

Diff Detail

Repository
rP Phorge
Branch
T15623min (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 800
Build 800: arc lint + arc unit

Event Timeline

Obviously not a clean tree, sorry. Thus ran arc liberate, now arc asked whether to include unstaged changes in src/__phutil_library_map__.php (yes)

and that's now wrong because src/__phutil_library_map__.php includes a non-existing file though I had ran git stash. I love git...

Try again, after an rm and arc liberate on master, and then a git rebase master on this branch

This revision is now accepted and ready to land.Aug 22 2023, 09:27