Differential D25364

Fix arc patch PHP 8.1 strlen(null) error
ClosedPublic
Actions

Authored by Sten on Jul 29 2023, 10:41.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15571: Arc Patch fails with PHP 8.1 strlen(null) error

Commits

rP4cedb928aa20: Fix arc patch PHP 8.1 strlen(null) error

Summary

Fix arc patch PHP 8.1 strlen(null) error.

When doing an 'arc patch Dxxxx' against a diff on a PHP 8.1 Phorge server we get a strlen(null) error.
Updating the idx call to provide a default empty string resolves it.
Providing a default empty string to

Fixes T15571

Test Plan

arc patch Dxxxx

Diff Detail

Repository

rP Phorge

Branch

PhabricatorConduitAPIController (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 706
Build 706: arc lint + arc unit

Event Timeline

Sten created this revision.Jul 29 2023, 10:41

Owners added a reviewer: O1: Blessed Committers.Jul 29 2023, 10:41

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 29 2023, 10:41

Sten requested review of this revision.Jul 29 2023, 10:41

Harbormaster completed remote builds in B705: Diff 1177.Jul 29 2023, 10:41

avivey accepted this revision.Jul 29 2023, 10:54

This revision is now accepted and ready to land.Jul 29 2023, 10:54

$edit_mode has a true value for 'create' or 'edit', and false (null) for read. The strlen() is superfluous.

Harbormaster completed remote builds in B706: Diff 1178.Jul 29 2023, 11:01

Request review for the second part of the change!

$edit_mode has a true value for 'create' or 'edit', and false (null) for read. The strlen() is superfluous.

maybe add that as a comment in there...

This revision is now accepted and ready to land.Jul 29 2023, 15:53

In D25364#10593, @avivey wrote:

$edit_mode has a true value for 'create' or 'edit', and false (null) for read. The strlen() is superfluous.

maybe add that as a comment in there...

It's already in the code - lines 52-53

Closed by commit rP4cedb928aa20: Fix arc patch PHP 8.1 strlen(null) error. · Explain WhyJul 29 2023, 16:36

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP4cedb928aa20: Fix arc patch PHP 8.1 strlen(null) error.