Ref T15064.
Details
Details
- Reviewers
valerio.bozzolan Sten - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4
- Commits
- rARC6e4947b55f09: Improve arc-browse for php 8.1
ran some arc browse commands in php 8.1, got no exceptions.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- phorge (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 656 Build 656: arc lint + arc unit
Event Timeline
Comment Actions
Thaanks
Tested with a directory, a file, a sub-file, a sub-directory. It still works ✨
| src/ref/ArcanistRepositoryRef.php | ||
|---|---|---|
| 82–84 | Simply checking for null and then letting the null continue on down isn't the best solution here, as it is subsequently put into the return string. | |
| src/ref/ArcanistRepositoryRef.php | ||
|---|---|---|
| 82–84 | I agree premising that the only use was "{$uri_base}" and it does not cause problems since (string) null is always casted to an empty string as expected. Just to say: it was weird (because PHP is weird) but under control. | |
| src/ref/ArcanistRepositoryRef.php | ||
|---|---|---|
| 82–84 | nice, you're right! | |
| src/ref/ArcanistRepositoryRef.php | ||
|---|---|---|
| 95–96 | By the way I can confirm this bug in Subversion ↑ | |
| src/ref/ArcanistRepositoryRef.php | ||
|---|---|---|
| 95–96 | have SVN repository and run arc browse? | |