Page MenuHomePhorge

Make sure `offset` is an integer
ClosedPublic

Authored by avivey on Apr 12 2024, 08:32.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 6, 23:07
Unknown Object (File)
Thu, Jun 6, 05:42
Unknown Object (File)
Wed, Jun 5, 16:19
Unknown Object (File)
Wed, Jun 5, 01:17
Unknown Object (File)
Wed, Jun 5, 00:28
Unknown Object (File)
Tue, Jun 4, 19:34
Unknown Object (File)
Tue, Jun 4, 17:52
Unknown Object (File)
Tue, Jun 4, 07:54

Details

Summary

Older git versions allowed the --skip to get empty string as value and interpreted that to an int.
We were sending null in some places where we wanted a 0, so it all worked out.

Since https://git.kernel.org/pub/scm/git/git.git/commit/revision.c?id=71a1e94821666909b7b2bd62a36244c601f8430e git fails when provided empty string for an integer.

See Q124 and T15783.

Test Plan

Have recent git version (that fails with --skip '', navigate to /diffusion/1/history/master/) - see history.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1164
Build 1164: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Apr 12 2024, 08:32

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

??

What for?

(Stupid question :D sorry - clear now)

sgtm

This revision is now accepted and ready to land.Apr 12 2024, 13:56
aklapper subscribed.

(I took the liberty to link the specific change in Git in the commit message)

This revision was automatically updated to reflect the committed changes.