Differential D25571

T15774: Celerity: javascript minification issue with template literals (backticked strings)
ClosedPublic
Actions

Authored by mturdus on Apr 7 2024, 11:49.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15774: Celerity: javascript minification issue with template literals (backticked strings)

Commits

rP214988fafd75: T15774: Celerity: javascript minification issue with template literals…

Test Plan

This archive contains a small demo:

ext-D25571.tar.gz1 KBDownload

When installed, an application named D25571 appears under "More Applications".
When you start it, you will see 2 messageboxes: one should be a single lined text, the other a multilined text.

Steps:

unpack archive in some directory
add ext-D25571/src/ path to load-libraries in local.json
bin/arc liberate
bin/cache purge --all
bin/celerity map
restart httpd
start D25571 application from More Applications

Also:

arc unit ./src/applications/celerity/__tests__/CelerityResourceTransformerTestCase.php

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mturdus created this revision.Apr 7 2024, 11:49

Owners added a reviewer: O1: Blessed Committers.Apr 7 2024, 11:49

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 7 2024, 11:49

mturdus requested review of this revision.Apr 7 2024, 11:49

Harbormaster completed remote builds in B1155: Diff 1828.Apr 7 2024, 11:49

mturdus retitled this revision from Summary: T15774. to T15774: Celerity: javascript minification issue with template literals (backticked strings).Apr 7 2024, 11:51

Write Phorge application extension which uses backticked strings containing spaces.

"uses" in which way(s)? Is there a chance that you could provide some minimal, self-contained testcase?

Verify the javascript content from your extension.

How? Could you provide clearer steps that allow others to test this? Thanks a lot!

mturdus edited the test plan for this revision. (Show Details)Apr 14 2024, 05:39

add unit test

It can be tested with:

arc unit ./src/applications/celerity/__tests__/CelerityResourceTransformerTestCase.php

Harbormaster completed remote builds in B1316: Diff 2066.Jun 4 2024, 01:25

The linter now screams nonsense things because of my little new unit test, taken from the proposed tar.gz file. Probably better than nothing. Tested A/B and it makes sense. Also the addition makes sense to me, compared to the other ones.

To God: please sorry us, for what we are doing here. We know, parsing JavaScript by regex is evil. But hey, it still works.

This revision is now accepted and ready to land.Jun 4 2024, 01:29

valerio.bozzolan edited the test plan for this revision. (Show Details)Jun 4 2024, 01:30

avivey added a task: T15774: Celerity: javascript minification issue with template literals (backticked strings).Jun 4 2024, 06:51

Please add some negative tests - things that could trigger this thing, but shouldn't.

For example

foo = "this isn't ` a `real` tick ";

"`there`; and back again";

There's maybe more possible things.

This revision was landed with ongoing or failed builds.Jun 11 2024, 15:09

Closed by commit rP214988fafd75: T15774: Celerity: javascript minification issue with template literals…. · Explain Why

This revision was automatically updated to reflect the committed changes.

mturdus added a commit: rP214988fafd75: T15774: Celerity: javascript minification issue with template literals….

Revision Contents
Changeset List

Path

Size

Packages

externals/

JsShrink/

jsShrink.php

11 lines

O1: Blessed Committers

Diff 2108

View Options

externals/JsShrink/jsShrink.php

T15774: Celerity: javascript minification issue with template literals (backticked strings)ClosedPublicActions