Page MenuHomePhorge

isSelfURI: fix anchors and relative URIs (that are "self" indeed)
ClosedPublic

Authored by valerio.bozzolan on Mar 9 2024, 22:30.

Details

Summary

Example cases that were wrongly considered external URLs:

  • "#foo"
  • "/foo"

Note that Phorge usually does not change stable things. In fact this thing
was not documented even inline, and was not even in the unit tests.

So this is a fix, and not a breaking change. Probably no one had ever tried it.

Closes T15182

Test Plan

The already existing unit tests still work.

The added ones make sense.

There are no problems doing other random things.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'm not a fan of "if not nonempty". Can I swap?

But this will make the Diff less readable.

This revision is now accepted and ready to land.Mar 19 2024, 11:27