Page MenuHomePhorge

isSelfURI: fix anchors and relative URIs (that are "self" indeed)
ClosedPublic

Authored by valerio.bozzolan on Mar 9 2024, 22:30.
Tags
None
Referenced Files
F2184902: D25555.diff
Thu, May 9, 13:56
Unknown Object (File)
Sun, May 5, 23:30
Unknown Object (File)
Sun, May 5, 01:57
Unknown Object (File)
Sat, May 4, 18:53
Unknown Object (File)
Sat, May 4, 18:53
Unknown Object (File)
Sat, Apr 27, 07:03
Unknown Object (File)
Mon, Apr 22, 22:33
Unknown Object (File)
Mon, Apr 22, 22:32

Details

Summary

Example cases that were wrongly considered external URLs:

  • "#foo"
  • "/foo"

Note that Phorge usually does not change stable things. In fact this thing
was not documented even inline, and was not even in the unit tests.

So this is a fix, and not a breaking change. Probably no one had ever tried it.

Closes T15182

Test Plan

The already existing unit tests still work.

The added ones make sense.

There are no problems doing other random things.

Diff Detail

Repository
rP Phorge
Branch
fix-is-self-url-without-domain
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1105
Build 1105: arc lint + arc unit