Paths

Table of Contentst

Fix cursor paging issue in Given Token query call
ClosedPublic
Actions

Authored by aklapper on Nov 5 2023, 14:37.

Tags

None

Referenced Files

	F3319519: D25455.1743308342.diff
	Sat, Mar 29, 04:19

	F3314403: D25455.1743230255.diff
	Fri, Mar 28, 06:37

	F3311226: D25455.1743202281.diff
	Thu, Mar 27, 22:51

	F3308047: D25455.1743158686.diff
	Thu, Mar 27, 10:44

	F3306702: D25455.1743130751.diff
	Thu, Mar 27, 02:59

	F3304664: D25455.1743103029.diff
	Wed, Mar 26, 19:17

	F3289806: D25455.1742853559.diff
	Sun, Mar 23, 21:59

	F3288936: D25455.1742838699.diff
	Sun, Mar 23, 17:51

Subscribers

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15652: Unhandled Exception: Call to undefined method PhabricatorTokenGivenQuery::withIDs()

Commits

rPdfa15726ea5a: Fix cursor paging issue in Given Token query call

Summary

The "Query" class for Given Token is missing a "withIDs()" method.

Call to undefined method PhabricatorTokenGivenQuery::withIDs() at [PhabricatorCursorPagedPolicyAwareQuery.php:120]

Closes T15652

Test Plan

Go to the Token page and pass a URL parameter, such as /token/given/?after=3

Diff Detail

Repository

rP Phorge

Branch

T15652tokenQuery (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 880
Build 880: arc lint + arc unit

Event Timeline

aklapper created this revision.Nov 5 2023, 14:37

Owners added a reviewer: O1: Blessed Committers.Nov 5 2023, 14:37

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 5 2023, 14:37

aklapper requested review of this revision.Nov 5 2023, 14:37

Harbormaster completed remote builds in B880: Diff 1439.Nov 5 2023, 14:37

Nice

This revision is now accepted and ready to land.Nov 5 2023, 15:09

Closed by commit rPdfa15726ea5a: Fix cursor paging issue in Given Token query call. · Explain WhyNov 9 2023, 20:01

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPdfa15726ea5a: Fix cursor paging issue in Given Token query call.

valerio.bozzolan mentioned this in Next Up.Nov 9 2023, 20:03

avivey mentioned this in 2023 week 49.Dec 8 2023, 17:36

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

tokens/

query/

PhabricatorTokenGivenQuery.php

13 lines

O1: Blessed Committers

Diff 1439

View Options

src/applications/tokens/query/PhabricatorTokenGivenQuery.php

Fix cursor paging issue in Given Token query callClosedPublicActions