Page MenuHomePhorge

log deprecation events in Dark Console
ClosedPublic

Authored by avivey on Aug 11 2023, 18:53.

Details

Summary

PhutilErrorHandler already defines "DEPRECATED" error class, but it's not used.
I plan to use it to report deprecation warnings.

With this change, they will be shown in the Dark Console and in the error logs

Ref T15554

This change on its own won't do anything, but is safe to land first.

Test Plan

With D25387, pages that have deprecation warnings are now shown, and the deprecation message is available in the dark console (and in log).

Diff Detail

Repository
rP Phorge
Branch
no-deprect-death
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 744
Build 744: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Aug 11 2023, 18:53

Tested with and without D25387.

SUPER NICE \o/

This revision is now accepted and ready to land.Aug 18 2023, 09:47