Page MenuHomePhorge

log deprecation events in Dark Console
ClosedPublic

Authored by avivey on Aug 11 2023, 18:53.
Tags
None
Referenced Files
F2303399: D25386.1721071635.diff
Sun, Jul 14, 19:27
Unknown Object (File)
Sun, Jul 14, 04:07
Unknown Object (File)
Sun, Jul 14, 02:51
Unknown Object (File)
Thu, Jul 11, 18:59
Unknown Object (File)
Mon, Jul 8, 16:26
Unknown Object (File)
Sun, Jul 7, 12:05
Unknown Object (File)
Sun, Jul 7, 00:33
Unknown Object (File)
Sat, Jul 6, 22:24

Details

Summary

PhutilErrorHandler already defines "DEPRECATED" error class, but it's not used.
I plan to use it to report deprecation warnings.

With this change, they will be shown in the Dark Console and in the error logs

Ref T15554

This change on its own won't do anything, but is safe to land first.

Test Plan

With D25387, pages that have deprecation warnings are now shown, and the deprecation message is available in the dark console (and in log).

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey requested review of this revision.Aug 11 2023, 18:53

Tested with and without D25387.

SUPER NICE \o/

This revision is now accepted and ready to land.Aug 18 2023, 09:47