Page MenuHomePhorge

Teach `./bin/celerity` about sprite maps
ClosedPublic

Authored by avivey on Jun 3 2023, 13:36.
Tags
None
Referenced Files
F3040224: D25274.1740945466.diff
Sat, Mar 1, 19:57
F3001341: D25274.1740441569.diff
Sun, Feb 23, 23:59
F3001340: D25274.1740441568.diff
Sun, Feb 23, 23:59
F3001339: D25274.1740441566.diff
Sun, Feb 23, 23:59
F2998538: D25274.1740413751.diff
Sun, Feb 23, 16:15
F2988397: D25274.1740150062.diff
Thu, Feb 20, 15:01
F2983558: D25274.1739992035.diff
Tue, Feb 18, 19:07
F2982416: D25274.1739958342.diff
Tue, Feb 18, 09:45
Tokens
"Grey Medal" token, awarded by valerio.bozzolan.

Details

Summary

Add ./bin/celerity sprites, to replace script ./scripts/celerity/generate_sprites.php.
Also make new workflow run ./bin/celerity map at the same time.

Fixes T15437.

Test Plan

Changes a file that goes in the sprites, run new command

Diff Detail

Repository
rP Phorge
Branch
cerlrity
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 508
Build 508: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Jun 3 2023, 13:36
src/applications/celerity/management/CelerityManagementGenerateSpritesWorkflow.php
14

I’m not immediately familiar with the details of the other scripts but is there another similar one to match a similar argument? E.g. if another script has a —no-cache argument we could use that instead of force.

22

Should this arg be wrapped in backticks or regular quotes?

avivey planned changes to this revision.Jun 3 2023, 16:09
avivey added inline comments.
src/applications/celerity/management/CelerityManagementGenerateSpritesWorkflow.php
22

Yeah, it should be regular quotes. Not sure what PHP does with backquotes in the text, but it's not an error...

avivey marked 2 inline comments as done.
  • fixes
src/applications/celerity/management/CelerityManagementGenerateSpritesWorkflow.php
14

Yeah, looks like no-map is the standard.

speck added inline comments.
src/applications/celerity/management/CelerityManagementGenerateSpritesWorkflow.php
14

Oh hah I was thinking the force argument but I see it’s from the original script too

This revision is now accepted and ready to land.Jun 3 2023, 16:48