Add ./bin/celerity sprites, to replace script ./scripts/celerity/generate_sprites.php.
Also make new workflow run ./bin/celerity map at the same time.
Fixes T15437.
Details
Details
- Reviewers
speck - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15437: add `celerity` command to generate sprite maps
- Commits
- rPcb938d869c3f: Teach `./bin/celerity` about sprite maps
Changes a file that goes in the sprites, run new command
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- cerlrity
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 508 Build 508: arc lint + arc unit
Event Timeline
| src/applications/celerity/management/CelerityManagementGenerateSpritesWorkflow.php | ||
|---|---|---|
| 14 | I’m not immediately familiar with the details of the other scripts but is there another similar one to match a similar argument? E.g. if another script has a —no-cache argument we could use that instead of force. | |
| 22 | Should this arg be wrapped in backticks or regular quotes? | |
| src/applications/celerity/management/CelerityManagementGenerateSpritesWorkflow.php | ||
|---|---|---|
| 22 | Yeah, it should be regular quotes. Not sure what PHP does with backquotes in the text, but it's not an error... | |
| src/applications/celerity/management/CelerityManagementGenerateSpritesWorkflow.php | ||
|---|---|---|
| 14 | Yeah, looks like no-map is the standard. | |
| src/applications/celerity/management/CelerityManagementGenerateSpritesWorkflow.php | ||
|---|---|---|
| 14 | Oh hah I was thinking the force argument but I see it’s from the original script too | |