Paths

Table of Contentst

-
src/ref/
-
ref/
1/1
ArcanistRefView.php

Differential D25206

Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc look remotes"
ClosedPublic
Actions

Authored by valerio.bozzolan on May 8 2023, 17:04.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15368: PHP 8.1 fix PhutilUTF8StringTruncator::truncateString(NULL) called at [<arcanist>/src/ref/ArcanistRefView.php:103]

Commits

rARC444bb60d4325: Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc…

Summary

This change fixes the command arc look remotes for PHP 8.1.

Without this change, the null value bubbles up to PhutilUTF8StringTruncator, reaching a strlen().

This control probably does not need to be done at this low level inside PhutilUTF8StringTruncator,
but it is right to be at this high level from the caller in ArcanistRefView.

Closes T15368

Test Plan

run "arc look remotes"
still works in "old PHP" like 7.4
start to work in recent PHP 8.1+

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.May 8 2023, 17:04

Owners added a reviewer: O1: Blessed Committers.May 8 2023, 17:04

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMay 8 2023, 17:04

valerio.bozzolan requested review of this revision.May 8 2023, 17:04

Harbormaster completed remote builds in B382: Diff 695.May 8 2023, 17:04

valerio.bozzolan mentioned this in T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).May 8 2023, 17:04

valerio.bozzolan mentioned this in T15368: PHP 8.1 fix PhutilUTF8StringTruncator::truncateString(NULL) called at [<arcanist>/src/ref/ArcanistRefView.php:103].May 8 2023, 17:07

valerio.bozzolan added inline comments.May 10 2023, 06:22

src/ref/ArcanistRefView.php
103	↑ here the problematic area - this should not receive null

valerio.bozzolan mentioned this in Z1: Phorge.May 12 2023, 09:33

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

Do you like this patch? :)

valerio.bozzolan mentioned this in 2023-05-22.May 22 2023, 13:47

Hi @Matthew :D super-safe thing here. Do you love this?

@Matthew feel free to "sgtm" <3

I think @speck maybe has better approaches here (do you know arc look? it's lovely)

Any feeling here? @avivey

avivey accepted this revision.Jun 1 2023, 15:38

This revision is now accepted and ready to land.Jun 1 2023, 15:38

Closed by commit rARC444bb60d4325: Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc…. · Explain WhyJun 1 2023, 16:20

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rARC444bb60d4325: Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc….

Revision Contents
Changeset List

Path

Size

Packages

src/

ref/

ArcanistRefView.php

5 lines

O1: Blessed Committers

Diff 862

View Options

src/ref/ArcanistRefView.php

Show All 18 Lines	public function handleRequest(AphrontRequest $request) {
if (!strlen($order)) {		if (!strlen($order)) {
$order = PhabricatorProjectColumnNaturalOrder::ORDERKEY;		$order = PhabricatorProjectColumnNaturalOrder::ORDERKEY;
}		}

$ordering = PhabricatorProjectColumnOrder::getOrderByKey($order);		$ordering = PhabricatorProjectColumnOrder::getOrderByKey($order);
$ordering = id(clone $ordering)		$ordering = id(clone $ordering)
->setViewer($viewer);		->setViewer($viewer);

		// When the Workboard view is "Group By <something>" the header provides
		// that context in JSON form
$edit_header = null;		$edit_header = null;
$raw_header = $request->getStr('header');		$raw_header = $request->getStr('header');
if (strlen($raw_header)) {		if (phutil_nonempty_string($raw_header)) {
		valerio.bozzolanUnsubmitted Done Inline Actions ✅ I verified that the above line is just null or a string The function `phutil_nonempty_string()` will report any alien type, and that is OK. valerio.bozzolan: ✅ I verified that the above line is just null or a string The function `phutil_nonempty_string…
$edit_header = phutil_json_decode($raw_header);		$edit_header = phutil_json_decode($raw_header);
} else {		} else {
$edit_header = array();		$edit_header = array();
}		}

$project = id(new PhabricatorProjectQuery())		$project = id(new PhabricatorProjectQuery())
->setViewer($viewer)		->setViewer($viewer)
->requireCapabilities(		->requireCapabilities(
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines

Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc look remotes"ClosedPublicActions