Differential D25130

Fix PHP 8.1 "strlen(null)" exception in AphrontRequest.php when cookieprefix not set
AbandonedPublic
Actions

Authored by aklapper on Apr 22 2023, 07:23.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15261: PHP 8.1 "strlen(null)" exception in AphrontRequest.php when cookieprefix not set

Summary

This change fixes a RuntimeException when setting up Phorge for the first time

Closes T15261

Test Plan

I got Phabricator instead of an error displayed in my web browser after changing this line

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 260
Build 260: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 22 2023, 07:23

Owners added a reviewer: O1: Blessed Committers.Apr 22 2023, 07:23

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 22 2023, 07:23

aklapper requested review of this revision.Apr 22 2023, 07:23

Harbormaster completed remote builds in B260: Diff 507.Apr 22 2023, 07:23

aklapper mentioned this in D25131: PHP 8.1 "preg_match(null)" exception in javelin/markup.php when http_action not set.Apr 22 2023, 07:39

Merged as part of D25131 instead

Revision Contents
Changeset List

Path

Size

Packages

src/

aphront/

AphrontRequest.php

2 lines

O1: Blessed Committers

Diff 507

View Options

src/aphront/AphrontRequest.php

Fix PHP 8.1 "strlen(null)" exception in AphrontRequest.php when cookieprefix not setAbandonedPublicActions